Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/General
    • Labels:
      None
    • Mantis ID:
      3243
    • Regression:
      No

      Description

      The attached patch is basically a rewrite of the "sip notify" facility that was put in yesterday (thanks to moc for the initial version!). The changes are:

      • only load the config file on load/reload, not every time the command is issued
      • move all "Via" header building into a function, instead of repeating the code for a sixth time
      • support CLI completion of notify type, in addition to peer name
      • only do completion of peer name when at the proper argument position
      • support sending to multiple peers with a single command
      • use ast_cli instead of ast_log for output that should only be sent to the console
      • confirm sending of each NOTIFY to the console
      • don't mark the NOTIFY messages for reliable sending, as they generally won't get a response
      • check the type before allocating any sip_pvt structures, in case it's bogus
                • ADDITIONAL INFORMATION ******

      Disclaimer is on file.

        Activity

        Hide
        mochouinard added a comment -

        Ok tested it and it working great except a small completion problem with the notify type, it wont complete after the reboot-... if I do reboot-p<TAB> it will put reboot-

        good job

        Show
        mochouinard added a comment - Ok tested it and it working great except a small completion problem with the notify type, it wont complete after the reboot-... if I do reboot-p<TAB> it will put reboot- good job
        Hide
        mochouinard added a comment -

        Uploaded the completion fix, and removed 2 unused variable. Let us know

        Show
        mochouinard added a comment - Uploaded the completion fix, and removed 2 unused variable. Let us know
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        Final rev... slight documentation change, and rename sample config entries to be easier to select via completion (and also to reflect that they don't directly reboot the phone, just ask for a "config check").

        Show
        Kevin P. Fleming (Inactive) added a comment - Final rev... slight documentation change, and rename sample config entries to be easier to select via completion (and also to reflect that they don't directly reboot the phone, just ask for a "config check").
        Hide
        nick added a comment -

        snom_notify.patch adds Snom-style reboots to the config file.

        Disclaimer on file (if that's even needed).

        Show
        nick added a comment - snom_notify.patch adds Snom-style reboots to the config file. Disclaimer on file (if that's even needed).
        Hide
        Mark Spencer added a comment -

        Added to CVS, thanks!

        Show
        Mark Spencer added a comment - Added to CVS, thanks!
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 4666

        U trunk/channels/chan_sip.c
        U trunk/configs/sip_notify.conf.sample

        ------------------------------------------------------------------------
        r4666 | markster | 2008-01-15 15:19:51 -0600 (Tue, 15 Jan 2008) | 2 lines

        Merge sip notify fixes (bug ASTERISK-3180)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=4666

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 4666 U trunk/channels/chan_sip.c U trunk/configs/sip_notify.conf.sample ------------------------------------------------------------------------ r4666 | markster | 2008-01-15 15:19:51 -0600 (Tue, 15 Jan 2008) | 2 lines Merge sip notify fixes (bug ASTERISK-3180 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4666

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development