Asterisk
  1. Asterisk
  2. ASTERISK-3476

[patch] libpri features - 2B channel transfer, MWI, callername over facility

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/General
    • Labels:
      None
    • Mantis ID:
      3554
    • Regression:
      No

      Description

      This is basically all of the changes that I have been doing to libpri for the past few months. Included features are callername over facility, two b channel transfer. If some people can take a look at this and test it that would be great.

                • ADDITIONAL INFORMATION ******

      Disclaimed

        Activity

        Hide
        mattf added a comment -

        Ok, committed the buglette fixes from PCadach

        Show
        mattf added a comment - Ok, committed the buglette fixes from PCadach
        Hide
        petersv added a comment -

        When can you use 2BCT (during call setup, after sending connect or both)? I think ECT and CD are limited to one or the other. Both are probably rose invokes.

        Where is the decision to invoke the 2BCT make? In the Dial application or by a lower layer? Can other handoff technologies hook in at the same place?

        CD/ECT allow extra information to be sent (reason for deflection etc). The information could be passed from the dialplan in a channel variable.

        Show
        petersv added a comment - When can you use 2BCT (during call setup, after sending connect or both)? I think ECT and CD are limited to one or the other. Both are probably rose invokes. Where is the decision to invoke the 2BCT make? In the Dial application or by a lower layer? Can other handoff technologies hook in at the same place? CD/ECT allow extra information to be sent (reason for deflection etc). The information could be passed from the dialplan in a channel variable.
        Hide
        Donny Kavanagh added a comment -

        Shoudn't we also be able to not use 2BCT if it is supported, there may be reasons where we want to keep the calls bridged through asterisk. Perhaps we need an option in Dial(..) to enable this functionality if it is supported. Or to disable it, which ever approach you feel is correct.

        Show
        Donny Kavanagh added a comment - Shoudn't we also be able to not use 2BCT if it is supported, there may be reasons where we want to keep the calls bridged through asterisk. Perhaps we need an option in Dial(..) to enable this functionality if it is supported. Or to disable it, which ever approach you feel is correct.
        Hide
        mattf added a comment -

        You can use 2BCT any time after the call SETUP message is sent (including during the PROCEEDING state, i.e. ringing). The decision to invoke a 2BCT is done in chan_zap.c, and is done in the existing native bridge mechanism in the ast_channel_bridge (if I remember correctly) function. Other technologies such as chan_iax.c and chan_sip.c for reinvites and the like.

        CD/ECT Transfer reason is already passed to the Dialplan in the $

        {PRIREDIRECTREASON}

        variable. See chan_zap.c for more info on it.

        I just changed it so that the "transfer" keyword in zapata.conf enables/disables 2BCT on channels.

        Show
        mattf added a comment - You can use 2BCT any time after the call SETUP message is sent (including during the PROCEEDING state, i.e. ringing). The decision to invoke a 2BCT is done in chan_zap.c, and is done in the existing native bridge mechanism in the ast_channel_bridge (if I remember correctly) function. Other technologies such as chan_iax.c and chan_sip.c for reinvites and the like. CD/ECT Transfer reason is already passed to the Dialplan in the $ {PRIREDIRECTREASON} variable. See chan_zap.c for more info on it. I just changed it so that the "transfer" keyword in zapata.conf enables/disables 2BCT on channels.
        Hide
        mattf added a comment -

        Fixed.

        Show
        mattf added a comment - Fixed.

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development