Asterisk
  1. Asterisk
  2. ASTERISK-3519

Audio delay in MeetMe using SIP when not 'q' mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      3599
    • Regression:
      No

      Description

      I've been doing some experiments with app_meetme, and only have SIP phones here to play with. I have been finding issues with audio delay that I think may be to do with the use of pseudo channels to conference non-Zap channels.

      I don't know whether the same issue applies to direct Zap channels or not.

      The easiest way to demonstrate it is first of all to make a pair of calls from SIP phones to an extension that calls MeetMe(2222|). Speaking into both phones and listening to them both gives an audio delay of about 300-400ms.

      Then repeat the experiment using MeetMe(2222|q). This time the audio comes back almost instantaneously.

      I suspect that the problem is something to do with the conf_play() of the enter and leave sounds. My guess is that by writing that raw data into the pseudo device fd, it causes a backlog that never drains, because the device is only getting emptied at the same rate as the conference is
      filling it.

      The delay does seem to be of approximately the same length as the enter sound.

      To test this theory, I commented out the call to careful_write() in conf_play(). Having done this, the delay was not present, even when not using the 'q' flag.

      My first attempt to fix this was not successful. I think it made an improvement, but it certainly did not eliminate the delay. The idea of the attempt was to count the number of bytes written to the pseudo-fd by conf_play(), and then to skip that number of bytes when relaying voice frames to that pseudo-fd. I've attached the patch to illustrate what I was trying, but it is NOT a solution. I think my understanding of the mechanism is still lacking.

                • ADDITIONAL INFORMATION ******

      Disclaimer on file.

        Activity

        Hide
        Kevin P. Fleming (Inactive) added a comment -

        OK, I'm not discounting the potential benefits of your patch regarding having the new caller hear the 'enter' sound (and maybe others), but Mark and I have come up with a far simpler solution that has solved the problems we've been able to reproduce (this one and ASTERISK-4224252). That solution is now in CVS HEAD.

        If you still experience these problems, please reopen the bug and we'll try to get it taken care of, but this should be resolved for good now

        Show
        Kevin P. Fleming (Inactive) added a comment - OK, I'm not discounting the potential benefits of your patch regarding having the new caller hear the 'enter' sound (and maybe others), but Mark and I have come up with a far simpler solution that has solved the problems we've been able to reproduce (this one and ASTERISK-4224252). That solution is now in CVS HEAD. If you still experience these problems, please reopen the bug and we'll try to get it taken care of, but this should be resolved for good now
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 5036

        U trunk/apps/app_meetme.c

        ------------------------------------------------------------------------
        r5036 | markster | 2008-01-15 15:25:28 -0600 (Tue, 15 Jan 2008) | 2 lines

        Begin autoservice while playing enter/leave sounds (bug ASTERISK-3519)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=5036

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 5036 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r5036 | markster | 2008-01-15 15:25:28 -0600 (Tue, 15 Jan 2008) | 2 lines Begin autoservice while playing enter/leave sounds (bug ASTERISK-3519 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5036
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 5131

        U trunk/apps/app_meetme.c

        ------------------------------------------------------------------------
        r5131 | markster | 2008-01-15 15:26:49 -0600 (Tue, 15 Jan 2008) | 2 lines

        Flush MeetMe at appropriate times (bug ASTERISK-3519)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=5131

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 5131 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r5131 | markster | 2008-01-15 15:26:49 -0600 (Tue, 15 Jan 2008) | 2 lines Flush MeetMe at appropriate times (bug ASTERISK-3519 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5131
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 5148

        U trunk/apps/app_meetme.c

        ------------------------------------------------------------------------
        r5148 | markster | 2008-01-15 15:27:03 -0600 (Tue, 15 Jan 2008) | 2 lines

        Fix meetme flushing stupidity (doh!) (bug ASTERISK-3519)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=5148

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 5148 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r5148 | markster | 2008-01-15 15:27:03 -0600 (Tue, 15 Jan 2008) | 2 lines Fix meetme flushing stupidity (doh!) (bug ASTERISK-3519 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5148
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 7033

        U trunk/ChangeLog
        U trunk/apps/app_meetme.c
        U trunk/configs/meetme.conf.sample

        ------------------------------------------------------------------------
        r7033 | kpfleming | 2008-01-15 15:55:00 -0600 (Tue, 15 Jan 2008) | 2 lines

        issues ASTERISK-3519 and ASTERISK-4152

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=7033

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 7033 U trunk/ChangeLog U trunk/apps/app_meetme.c U trunk/configs/meetme.conf.sample ------------------------------------------------------------------------ r7033 | kpfleming | 2008-01-15 15:55:00 -0600 (Tue, 15 Jan 2008) | 2 lines issues ASTERISK-3519 and ASTERISK-4152 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7033

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development