Asterisk
  1. Asterisk
  2. ASTERISK-3564

[patch] Changes to devstate, message and subscribe

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      3644
    • Regression:
      No

      Description

      This patch

      • Adds changes to devicestate
        Checking peer status based on incominglimit and qualify=
      • Adds third XML format for SUBSCRIBE notifications
        for xten Eye-beam
      • Improving SUBSCRIBE handling
      • Checking subscription Event: header
      • Generating error message if we do not support
        event package
      • Authentication as REGISTER (www-auth)
      • Fixes bugs in "sip show subscriptions"

      Disclaimer on file

                • ADDITIONAL INFORMATION ******

      This patch does not change current behaviour, but improves handling of unknown SUBSCRIBE event packages (error message), adds a new event notification format and fixes small errors in the way we receive MESSAGEs.

      1. 0003644-ast_build_string_rev1.diff.txt
        2 kB
      2. 0003644-sipdiverse.txt
        17 kB
      3. 0003644-subscribe.txt
        38 kB
      4. 0003644-subscribe2.txt
        23 kB
      5. 0003644-subscribe-20050428.diff.txt
        33 kB
      6. 0003644-subscribe3.txt
        22 kB
      7. 0003644-subscribe-merged-with-3882.diff.txt
        29 kB
      8. 0003644-subscribe-merged-with-3882.diff.txt
        29 kB
      9. polycom-sub.txt
        35 kB
      10. polycom-sub-debug.txt
        230 kB
      11. sip3644-0828.txt
        39 kB
      12. sip3644-0829.txt
        39 kB
      13. sip3644-0829b.txt
        39 kB
      14. sip3644-0829c.txt
        40 kB
      15. sipsubscribe_polycom_support.txt
        0.6 kB
      16. sipsubscribe0610.txt
        28 kB
      17. sipsubscribe-20050622.rev768.txt
        30 kB
      18. sipsubscribe-20050623.rev770.txt
        43 kB
      19. sipsubscribe-20050627.rev771.txt
        43 kB
      20. sipsubscribe-20050706.rev774.txt
        43 kB
      21. sipsubscribe-20050708.rev775.txt
        43 kB
      22. sipsubscribe-20050715.rev779.txt
        160 kB
      23. sipsubscribe-20050718.rev781.txt
        57 kB
      24. sipsubscribe-20050720.rev783.txt
        58 kB
      25. sipsubscribe-20050725.rev787.txt
        29 kB
      26. sipsubscribe-20050725.rev789.txt
        29 kB
      27. sipsubscribe-20050726.rev792.txt
        28 kB
      28. sipsubscribe-20050726.rev792v2.txt
        29 kB
      29. sipsubscribe-20050726.rev796.txt
        29 kB
      30. sipsubscribe-20050729.rev797.txt
        29 kB
      31. sipsubscribe-20050801.rev797.txt
        29 kB
      32. sipsubscribe-20050803.rev801.txt
        29 kB
      33. sipsubscribe-20050812.rev806.txt
        29 kB
      34. sipsubscribe-20050812.rev806v2.txt
        30 kB
      35. sipsubscribe-20050823.rev813.txt
        30 kB
      36. sipsubscribe-20050824.rev814.txt
        36 kB
      37. sipsubscribe-20050824.rev814v2.txt
        36 kB
      38. sipsubscribe-20050825.rev820.txt
        39 kB
      39. sipsubscribe-20050825.rev820v2.txt
        39 kB
      40. sipsubscribe-20050829.rev822.txt
        42 kB
      41. subscribe0824.txt
        34 kB
      42. subscribe-20050531.diff.txt
        31 kB

        Activity

        Hide
        Olle Johansson added a comment -

        Can you please try this patch as well? We now refuse the subscription if there's no hint and log an error message to the console.

        Show
        Olle Johansson added a comment - Can you please try this patch as well? We now refuse the subscription if there's no hint and log an error message to the console.
        Hide
        wjchan added a comment -

        couple of typos in the patch:

        firstate -> firststate (2 occurences)

        "Please add hint to...." missing closing quote.

        Other than those, the patch is fine.

        Show
        wjchan added a comment - couple of typos in the patch: firstate -> firststate (2 occurences) "Please add hint to...." missing closing quote. Other than those, the patch is fine.
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        Committed to CVS HEAD, thanks!

        Show
        Kevin P. Fleming (Inactive) added a comment - Committed to CVS HEAD, thanks!
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 5684

        U trunk/include/asterisk/utils.h
        U trunk/utils.c

        ------------------------------------------------------------------------
        r5684 | kpfleming | 2008-01-15 15:34:50 -0600 (Tue, 15 Jan 2008) | 2 lines

        add ast_build_string library function (from bug ASTERISK-3564)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=5684

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 5684 U trunk/include/asterisk/utils.h U trunk/utils.c ------------------------------------------------------------------------ r5684 | kpfleming | 2008-01-15 15:34:50 -0600 (Tue, 15 Jan 2008) | 2 lines add ast_build_string library function (from bug ASTERISK-3564 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5684
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 6446

        U trunk/channels/chan_sip.c
        U trunk/include/asterisk/pbx.h
        U trunk/pbx.c

        ------------------------------------------------------------------------
        r6446 | kpfleming | 2008-01-15 15:46:06 -0600 (Tue, 15 Jan 2008) | 2 lines

        massive upgrade to SUBSCRIBE, device state and messaging support (issue ASTERISK-3564)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=6446

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 6446 U trunk/channels/chan_sip.c U trunk/include/asterisk/pbx.h U trunk/pbx.c ------------------------------------------------------------------------ r6446 | kpfleming | 2008-01-15 15:46:06 -0600 (Tue, 15 Jan 2008) | 2 lines massive upgrade to SUBSCRIBE, device state and messaging support (issue ASTERISK-3564 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6446

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development