[Home]

Summary:ASTERISK-03625: [patch] H.263+ video codec support (passthru)
Reporter:paradise (paradise)Labels:
Date Opened:2005-03-03 10:37:40.000-0600Date Closed:2008-01-15 15:27:05.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/CodecInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) error.txt
( 1) h263plus.patch.txt
( 2) h263plus.patch.v2.txt
( 3) h263plus.patch.v3.txt
( 4) h263plus.patch.v4.txt
Description:this patch adds passthru support for H.263+ codec to *.
it's tested with eyeBeam and works fine!


****** ADDITIONAL INFORMATION ******

Disclaimer on file (if needed!)
Paradise Dove (pardove@gmail.com)
Comments:By: paradise (paradise) 2005-03-03 10:47:12.000-0600

typo in patch fixed!

By: Mark Spencer (markster) 2005-03-03 11:10:52.000-0600

Patch does not appear to apply to CVS head.  Is it getting damaged in the upload process somehow (e.g. tab/space conversion)?

By: Mark Spencer (markster) 2005-03-03 11:11:10.000-0600

Also, is H.263+ not compatible with H.263?

By: paradise (paradise) 2005-03-03 11:31:11.000-0600

- i will check the patch
- the only difference is the RTP payload type
- H.263+ video quality is much better!

edited on: 03-03-05 11:32

By: paradise (paradise) 2005-03-03 11:51:52.000-0600

suppose that the latest patch works now!

By: paradise (paradise) 2005-03-05 00:06:08.000-0600

did you test it?

By: muppetmaster (muppetmaster) 2005-03-05 10:56:52.000-0600

I added version three of the patch to my Asterisk instance (using the latest head as of March 5, 2005) and then attempt to place a call between two h.263 capable end-points (Eyebeam) and I still get the attached error (error.txt) when I try a video call.

I do have this configuration:

[general]
videosupport=yes

[3004]
disallow=all
allow=h263

[3005]
disallow=all
allow=h263

edited on: 03-05-05 11:10

By: paradise (paradise) 2005-03-05 11:51:19.000-0600

are u sure that the patch is applied properly?

By: paradise (paradise) 2005-03-05 12:03:18.000-0600

use version 4, it works now!

By: muppetmaster (muppetmaster) 2005-03-05 12:34:37.000-0600

I do believe it is patched properly as I did it manually and it does compile.  Also, I can not see any difference between v3 and v4.

By: Mark Spencer (markster) 2005-03-05 14:59:07.000-0600

I just manually patched it :)  Also changed h263+ to h263p in case the "+" ends up being used in something else.

By: Russell Bryant (russell) 2005-03-07 03:19:08.000-0600

not included in 1.0 since it is a new feature

By: Digium Subversion (svnbot) 2008-01-15 15:27:05.000-0600

Repository: asterisk
Revision: 5149

U   trunk/frame.c
U   trunk/include/asterisk/frame.h
U   trunk/rtp.c

------------------------------------------------------------------------
r5149 | markster | 2008-01-15 15:27:04 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge H.263+ support (bug ASTERISK-3625)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5149