Asterisk
  1. Asterisk
  2. ASTERISK-3961

[patch] goto_on_transfer for blind #transfer

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Resources/res_features
    • Labels:
      None
    • Mantis ID:
      4056
    • Regression:
      No

      Description

      This patch looks for the variable GOTO_ON_TRANSFER in a # transferring channel and sends the transferrer to that context|exten|pri (you can use ^ to represent | to avoid escapes)

      The patch also fixes a bug in pbx.c:ast_parseable_goto where non-pbx chans are not handled correctly

      exten => 3001,1,SetVar(GOTO_ON_TRANSFER=woohoo^s^1)
      exten => 3001,2,Dial(SIP/10.3.3.6|60|Tt)

      complete a # transfer and you will end up at woohoo,s,1

                • ADDITIONAL INFORMATION ******

      Disclaimer on File
      anthmct@yahoo.com

        Activity

        Hide
        Matt O'Gorman (Inactive) added a comment -

        thanks

        Show
        Matt O'Gorman (Inactive) added a comment - thanks
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        The comment directly above your code change in pbx.c says "This channel is currently in the PBX". Should that comment be removed, given that it appears to be wrong?

        The documentation update shouldn't refer to "# blind transfer", as the admin may have assigned a different key to the blind transfer functionality.

        Do you intend for this to apply to attended transfers as well? If not, we'll need to change the variable name, because right now it would be logical to assume it applies to all transfers...

        Show
        Kevin P. Fleming (Inactive) added a comment - The comment directly above your code change in pbx.c says "This channel is currently in the PBX". Should that comment be removed, given that it appears to be wrong? The documentation update shouldn't refer to "# blind transfer", as the admin may have assigned a different key to the blind transfer functionality. Do you intend for this to apply to attended transfers as well? If not, we'll need to change the variable name, because right now it would be logical to assume it applies to all transfers...
        Hide
        Anthony Minessale added a comment -

        attended transfer by nature is what it is because you hang up so it's not possible to transfer the transferer

        be my guest to make any changes you see fit, I did this patch to be nice for matt and I have no furthur plans to edit it.

        Show
        Anthony Minessale added a comment - attended transfer by nature is what it is because you hang up so it's not possible to transfer the transferer be my guest to make any changes you see fit, I did this patch to be nice for matt and I have no furthur plans to edit it.
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        You are correct, an attended transfer can't support this functionality.

        I'll take this ball and run with it, thanks.

        Show
        Kevin P. Fleming (Inactive) added a comment - You are correct, an attended transfer can't support this functionality. I'll take this ball and run with it, thanks.
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        Committed to CVS, with modifications. Thanks!

        Show
        Kevin P. Fleming (Inactive) added a comment - Committed to CVS, with modifications. Thanks!
        Hide
        Russell Bryant added a comment -

        not applicable to 1.0

        Show
        Russell Bryant added a comment - not applicable to 1.0
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 5495

        U trunk/doc/README.variables
        U trunk/pbx.c
        U trunk/res/res_features.c

        ------------------------------------------------------------------------
        r5495 | kpfleming | 2008-01-15 15:32:03 -0600 (Tue, 15 Jan 2008) | 2 lines

        add ability to send transferring party to a dialplan target after they blind transfer another party (bug ASTERISK-3961, with mods)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=5495

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 5495 U trunk/doc/README.variables U trunk/pbx.c U trunk/res/res_features.c ------------------------------------------------------------------------ r5495 | kpfleming | 2008-01-15 15:32:03 -0600 (Tue, 15 Jan 2008) | 2 lines add ability to send transferring party to a dialplan target after they blind transfer another party (bug ASTERISK-3961 , with mods) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5495

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development