Asterisk
  1. Asterisk
  2. ASTERISK-5367

[patch] [post 1.2] Cannot track device state of MGCP channels

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Channels/chan_mgcp
    • Labels:
      None
    • Mantis ID:
      5515
    • Regression:
      No

      Description

      Cannot track the device state of MGCP devices using hint mechanism
      because the devicestate callback was not defined for MGCP. Patch
      attached implements the devicestate callback for MGCP.

        Activity

        Hide
        Olle Johansson added a comment -

        Thank you for contributing to Asterisk!

        BTW, if you have time, could you please take a moment and add some explanatory doxygen comments to chan_mgcp, like we have in chan_sip? It needs a bit of documentation.

        Show
        Olle Johansson added a comment - Thank you for contributing to Asterisk! BTW, if you have time, could you please take a moment and add some explanatory doxygen comments to chan_mgcp, like we have in chan_sip? It needs a bit of documentation.
        Hide
        gkloepfer added a comment -

        Will add the dox and have a new patch by the end of the day today.

        Show
        gkloepfer added a comment - Will add the dox and have a new patch by the end of the day today.
        Hide
        gkloepfer added a comment -

        updated diff chan_mgcp.c.diff.1026 added that is diff'd against
        the 26-Oct-2005 -HEAD along with some doxygen tags added.

        My code is formatted according to the coding guidelines, but
        the remainder of chan_mgcp.c isn't. I tried to get some
        tags where I could add some, but chan_mgcp.c really needs some
        review by the folks who wrote it (I can't tell if the two-letter
        abbreviations all over the code has specific meaning, or if it's
        the initials of the people modifying the code, which would be
        contrary to the coding standards).

        In any case, my contribution does have the tags documenting the
        parameters and return values.

        It has also been pretty well tested by this point and appears to
        function OK.

        Show
        gkloepfer added a comment - updated diff chan_mgcp.c.diff.1026 added that is diff'd against the 26-Oct-2005 -HEAD along with some doxygen tags added. My code is formatted according to the coding guidelines, but the remainder of chan_mgcp.c isn't. I tried to get some tags where I could add some, but chan_mgcp.c really needs some review by the folks who wrote it (I can't tell if the two-letter abbreviations all over the code has specific meaning, or if it's the initials of the people modifying the code, which would be contrary to the coding standards). In any case, my contribution does have the tags documenting the parameters and return values. It has also been pretty well tested by this point and appears to function OK.
        Hide
        philipp2 added a comment -

        Works fine here so far on 1.2.0

        Show
        philipp2 added a comment - Works fine here so far on 1.2.0
        Hide
        philipp2 added a comment -

        What is keeping this from going into SVN, or even into 1.2.2? This is not exactly a new feature, it rather completes the hint support.

        Show
        philipp2 added a comment - What is keeping this from going into SVN, or even into 1.2.2? This is not exactly a new feature, it rather completes the hint support.
        Hide
        Olle Johansson added a comment -

        I recommend this for svn trunk.

        Show
        Olle Johansson added a comment - I recommend this for svn trunk.
        Hide
        Tilghman Lesher added a comment -

        Committed to trunk.

        Show
        Tilghman Lesher added a comment - Committed to trunk.

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development