Asterisk
  1. Asterisk
  2. ASTERISK-5773

[patch] Japanese Caller ID retrieval for TDM400P

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      5928
    • Regression:
      No

      Description

      added functionality to channels/channel_zap.c and callerid.c
      to retrieve Japanese caller id from analog lines with using TDM400p.
      the way to retrieve caller id is different from US and Japan.
      in US,telco sends caller id as soon as they change polarity of the line,
      in the other hand, Japanese telco waits until we pick up a phone
      to indicate that we are ready to retrieve a caller id,
      after we retrieve the caller id, we need to on-hook the line,
      this will indicate that we are ready to get an actual call,
      telco catched our on-hooking, it again rings the line so that we can
      pick up the line and start talking to the caller.

      in this release of patch, it does not perform CRC error code
      cheking, I will put that functionality in the future.

        Activity

        Hide
        Russell Bryant added a comment -

        First thing - there are some formatting issues in your patch. Please read the doc/CODING-GUIDELINES document with regards to the use of spacing and placement of curly braces.

        Thanks!

        Show
        Russell Bryant added a comment - First thing - there are some formatting issues in your patch. Please read the doc/CODING-GUIDELINES document with regards to the use of spacing and placement of curly braces. Thanks!
        Hide
        Takeshi Hiragimoto added a comment -

        Thank you for cheking my code,
        I just modified my code to fit the requirements.
        Thank you

        Show
        Takeshi Hiragimoto added a comment - Thank you for cheking my code, I just modified my code to fit the requirements. Thank you
        Hide
        Takeshi Hiragimoto added a comment -

        just completed to write full version of japanese caller id retrieval functionality (asterisk-japanese_callerid-2005Dec16.patch), in this version, it performs CRC checking and also it detects all possible information from telco.
        thank you,

        Show
        Takeshi Hiragimoto added a comment - just completed to write full version of japanese caller id retrieval functionality (asterisk-japanese_callerid-2005Dec16.patch), in this version, it performs CRC checking and also it detects all possible information from telco. thank you,
        Hide
        mattf added a comment -

        Committed, Thanks!

        Show
        mattf added a comment - Committed, Thanks!
        Hide
        mattf added a comment -

        In trunk now!

        Show
        mattf added a comment - In trunk now!
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 7842

        U trunk/callerid.c
        U trunk/channels/chan_zap.c
        U trunk/include/asterisk/callerid.h

        ------------------------------------------------------------------------
        r7842 | mattf | 2008-01-15 16:12:09 -0600 (Tue, 15 Jan 2008) | 2 lines

        Changes to allow receiving japanese callerid (Bug ASTERISK-5773)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=7842

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 7842 U trunk/callerid.c U trunk/channels/chan_zap.c U trunk/include/asterisk/callerid.h ------------------------------------------------------------------------ r7842 | mattf | 2008-01-15 16:12:09 -0600 (Tue, 15 Jan 2008) | 2 lines Changes to allow receiving japanese callerid (Bug ASTERISK-5773 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7842

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development