Summary: | ASTERISK-05773: [patch] Japanese Caller ID retrieval for TDM400P | ||
Reporter: | Takeshi Hiragimoto (hfritz) | Labels: | |
Date Opened: | 2005-12-04 04:04:38.000-0600 | Date Closed: | 2008-01-15 16:12:09.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_indications |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk-japanese_callerid-2005Dec04.patch ( 1) asterisk-japanese_callerid-2005Dec06.patch ( 2) asterisk-japanese_callerid-2005Dec16.patch | |
Description: | added functionality to channels/channel_zap.c and callerid.c to retrieve Japanese caller id from analog lines with using TDM400p. the way to retrieve caller id is different from US and Japan. in US,telco sends caller id as soon as they change polarity of the line, in the other hand, Japanese telco waits until we pick up a phone to indicate that we are ready to retrieve a caller id, after we retrieve the caller id, we need to on-hook the line, this will indicate that we are ready to get an actual call, telco catched our on-hooking, it again rings the line so that we can pick up the line and start talking to the caller. in this release of patch, it does not perform CRC error code cheking, I will put that functionality in the future. | ||
Comments: | By: Russell Bryant (russell) 2005-12-05 15:03:57.000-0600 First thing - there are some formatting issues in your patch. Please read the doc/CODING-GUIDELINES document with regards to the use of spacing and placement of curly braces. Thanks! By: Takeshi Hiragimoto (hfritz) 2005-12-06 07:35:44.000-0600 Thank you for cheking my code, I just modified my code to fit the requirements. Thank you By: Takeshi Hiragimoto (hfritz) 2005-12-15 11:01:09.000-0600 just completed to write full version of japanese caller id retrieval functionality (asterisk-japanese_callerid-2005Dec16.patch), in this version, it performs CRC checking and also it detects all possible information from telco. thank you, By: Matthew Fredrickson (mattf) 2006-01-06 13:04:01.000-0600 Committed, Thanks! By: Matthew Fredrickson (mattf) 2006-01-06 13:04:45.000-0600 In trunk now! By: Digium Subversion (svnbot) 2008-01-15 16:12:09.000-0600 Repository: asterisk Revision: 7842 U trunk/callerid.c U trunk/channels/chan_zap.c U trunk/include/asterisk/callerid.h ------------------------------------------------------------------------ r7842 | mattf | 2008-01-15 16:12:09 -0600 (Tue, 15 Jan 2008) | 2 lines Changes to allow receiving japanese callerid (Bug ASTERISK-5773) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7842 |