| Summary: | ASTERISK-06161: [patch] segfault in channel.c::copy_data_from_queue - copies too many bytes | ||
| Reporter: | Steve Davies . (stevedavies) | Labels: | |
| Date Opened: | 2006-01-22 10:27:17.000-0600 | Date Closed: | 2008-01-15 16:28:31.000-0600 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) channel.c-copytherightnumberofbytes.patch | |
| Description: | Testing MixMonitor under load this weekend resulted in dozens of segfaults over the course of a few hours, all in copy_data_from_queue. The offending code is here: tocopy = (f->samples > samples) ? samples : f->samples; bytestocopy = ast_codec_get_len(queue->format, samples); memcpy(buf, f->data, bytestocopy); "tocopy" is the smaller of the samples wanted and the samples in the frame. But having worked that out, the code just uses the "samples" anyway. So whenever a smaller than usual frame comes along, we read past its end. A patch is attached; having applied this patch, my Asterisk has run all afternoon. Steve ****** ADDITIONAL INFORMATION ****** bug present in trunk and branch 1.2. the patch is against trunk. | ||
| Comments: | By: Russell Bryant (russell) 2006-01-22 11:05:19.000-0600 added to the 1.2 branch and trunk in revisions 8437 and 8438, good catch! By: Digium Subversion (svnbot) 2008-01-15 16:21:16.000-0600 Repository: asterisk Revision: 8437 U branches/1.2/channel.c ------------------------------------------------------------------------ r8437 | russell | 2008-01-15 16:21:15 -0600 (Tue, 15 Jan 2008) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8437 By: Digium Subversion (svnbot) 2008-01-15 16:21:17.000-0600 Repository: asterisk Revision: 8438 _U trunk/ U trunk/channel.c ------------------------------------------------------------------------ r8438 | russell | 2008-01-15 16:21:16 -0600 (Tue, 15 Jan 2008) | 10 lines Merged revisions 8437 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8437 | russell | 2006-01-22 12:47:13 -0500 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8438 By: Digium Subversion (svnbot) 2008-01-15 16:21:34.000-0600 Repository: asterisk Revision: 8453 _U team/russell/autoconf_and_menuselect/ U team/russell/autoconf_and_menuselect/app.c U team/russell/autoconf_and_menuselect/apps/Makefile U team/russell/autoconf_and_menuselect/apps/app_authenticate.c U team/russell/autoconf_and_menuselect/apps/app_chanspy.c U team/russell/autoconf_and_menuselect/apps/app_curl.c U team/russell/autoconf_and_menuselect/apps/app_db.c U team/russell/autoconf_and_menuselect/apps/app_dial.c U team/russell/autoconf_and_menuselect/apps/app_dictate.c U team/russell/autoconf_and_menuselect/apps/app_directory.c U team/russell/autoconf_and_menuselect/apps/app_disa.c U team/russell/autoconf_and_menuselect/apps/app_exec.c U team/russell/autoconf_and_menuselect/apps/app_externalivr.c U team/russell/autoconf_and_menuselect/apps/app_festival.c U team/russell/autoconf_and_menuselect/apps/app_hasnewvoicemail.c U team/russell/autoconf_and_menuselect/apps/app_image.c U team/russell/autoconf_and_menuselect/apps/app_macro.c U team/russell/autoconf_and_menuselect/apps/app_meetme.c U team/russell/autoconf_and_menuselect/apps/app_mixmonitor.c U team/russell/autoconf_and_menuselect/apps/app_osplookup.c U team/russell/autoconf_and_menuselect/apps/app_page.c U team/russell/autoconf_and_menuselect/apps/app_parkandannounce.c U team/russell/autoconf_and_menuselect/apps/app_playback.c U team/russell/autoconf_and_menuselect/apps/app_privacy.c U team/russell/autoconf_and_menuselect/apps/app_queue.c U team/russell/autoconf_and_menuselect/apps/app_random.c U team/russell/autoconf_and_menuselect/apps/app_read.c U team/russell/autoconf_and_menuselect/apps/app_readfile.c U team/russell/autoconf_and_menuselect/apps/app_record.c U team/russell/autoconf_and_menuselect/apps/app_sayunixtime.c U team/russell/autoconf_and_menuselect/apps/app_senddtmf.c U team/russell/autoconf_and_menuselect/apps/app_sendtext.c U team/russell/autoconf_and_menuselect/apps/app_setcallerid.c U team/russell/autoconf_and_menuselect/apps/app_skel.c U team/russell/autoconf_and_menuselect/apps/app_sql_postgres.c U team/russell/autoconf_and_menuselect/apps/app_stack.c U team/russell/autoconf_and_menuselect/apps/app_talkdetect.c U team/russell/autoconf_and_menuselect/apps/app_transfer.c U team/russell/autoconf_and_menuselect/apps/app_url.c U team/russell/autoconf_and_menuselect/apps/app_userevent.c U team/russell/autoconf_and_menuselect/apps/app_verbose.c U team/russell/autoconf_and_menuselect/apps/app_voicemail.c U team/russell/autoconf_and_menuselect/apps/app_while.c U team/russell/autoconf_and_menuselect/apps/app_zapras.c U team/russell/autoconf_and_menuselect/callerid.c U team/russell/autoconf_and_menuselect/channel.c U team/russell/autoconf_and_menuselect/channels/chan_agent.c U team/russell/autoconf_and_menuselect/channels/chan_iax2.c U team/russell/autoconf_and_menuselect/channels/chan_sip.c U team/russell/autoconf_and_menuselect/doc/README.variables U team/russell/autoconf_and_menuselect/funcs/func_cdr.c U team/russell/autoconf_and_menuselect/funcs/func_cut.c U team/russell/autoconf_and_menuselect/funcs/func_logic.c U team/russell/autoconf_and_menuselect/funcs/func_math.c U team/russell/autoconf_and_menuselect/funcs/func_md5.c U team/russell/autoconf_and_menuselect/funcs/func_strings.c U team/russell/autoconf_and_menuselect/include/asterisk/astosp.h U team/russell/autoconf_and_menuselect/pbx.c U team/russell/autoconf_and_menuselect/res/res_crypto.c U team/russell/autoconf_and_menuselect/res/res_features.c U team/russell/autoconf_and_menuselect/res/res_indications.c U team/russell/autoconf_and_menuselect/res/res_monitor.c U team/russell/autoconf_and_menuselect/res/res_musiconhold.c U team/russell/autoconf_and_menuselect/res/res_osp.c ------------------------------------------------------------------------ r8453 | russell | 2008-01-15 16:21:33 -0600 (Tue, 15 Jan 2008) | 122 lines Merged revisions 8401-8404,8407-8411,8413,8420-8422,8426,8428,8432,8436,8438,8443,8446-8447 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8401 | russell | 2006-01-21 15:20:06 -0500 (Sat, 21 Jan 2006) | 3 lines finish reverting my pass through the tree to remove checks of the result of ast_strdupa, this one is revision 8362 ................ r8402 | tilghman | 2006-01-21 15:32:17 -0500 (Sat, 21 Jan 2006) | 2 lines Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2) ................ r8403 | russell | 2006-01-21 15:57:06 -0500 (Sat, 21 Jan 2006) | 2 lines on this pass, only remove duplicate log messages ................ r8404 | russell | 2006-01-21 15:58:57 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8407 | russell | 2006-01-21 16:29:06 -0500 (Sat, 21 Jan 2006) | 2 lines clean up formatting to conform to coding guidelines and fix some typos (issue ASTERISK-6101) ................ r8408 | russell | 2006-01-21 16:50:09 -0500 (Sat, 21 Jan 2006) | 5 lines - conversion to allocation wrappers - get rid of some compiler warnings due to usused variables and const-ification - remove some unnecessary uses of malloc/strncpy/free and replace with ast_strdupa (based on the patch from issue ASTERISK-6115) ................ r8409 | russell | 2006-01-21 16:57:01 -0500 (Sat, 21 Jan 2006) | 2 lines oops, don't build app_sql_postgres by default ... ................ r8410 | russell | 2006-01-21 17:09:06 -0500 (Sat, 21 Jan 2006) | 5 lines - conversions to allocation wrappers - replace malloc/memset with ast_calloc - replace malloc/ast_copy_string with ast_strdup (based on patch from issue ASTERISK-6139) ................ r8411 | russell | 2006-01-21 18:05:19 -0500 (Sat, 21 Jan 2006) | 2 lines const-ify some fields in the ast_exten and ast_include structures (issue ASTERISK-6110) ................ r8413 | russell | 2006-01-21 18:17:52 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8420 | russell | 2006-01-21 21:06:33 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8421 | russell | 2006-01-21 21:10:19 -0500 (Sat, 21 Jan 2006) | 3 lines prevent writing outside of the provided workspace when calculating a substring (issue ASTERISK-6111) ................ r8422 | russell | 2006-01-21 21:23:38 -0500 (Sat, 21 Jan 2006) | 2 lines add 'show channeltype' CLI command (issue ASTERISK-5992, with small modifications) ................ r8426 | tilghman | 2006-01-22 02:18:02 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6148 - Add PARKEDAT variable; also cleaned up application help to fit 80-column screen. ................ r8428 | tilghman | 2006-01-22 03:09:02 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6262 - New function STRPTIME ................ r8432 | bweschke | 2006-01-22 10:08:51 -0500 (Sun, 22 Jan 2006) | 2 lines Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953 ................ r8436 | tilghman | 2006-01-22 12:28:42 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6312 - Macro janitor ................ r8438 | russell | 2006-01-22 12:53:14 -0500 (Sun, 22 Jan 2006) | 10 lines Merged revisions 8437 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8437 | russell | 2006-01-22 12:47:13 -0500 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ ................ r8443 | russell | 2006-01-22 13:42:06 -0500 (Sun, 22 Jan 2006) | 2 lines eliminate some compiler warnings ................ r8446 | russell | 2006-01-22 14:04:37 -0500 (Sun, 22 Jan 2006) | 1 line ................ r8447 | russell | 2006-01-22 14:09:50 -0500 (Sun, 22 Jan 2006) | 2 lines fix memory leak from not freeing the list of queue members when freeing a queue ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8453 By: Digium Subversion (svnbot) 2008-01-15 16:21:36.000-0600 Repository: asterisk Revision: 8455 _U team/russell/make_output/ U team/russell/make_output/apps/Makefile U team/russell/make_output/apps/app_authenticate.c U team/russell/make_output/apps/app_chanspy.c U team/russell/make_output/apps/app_curl.c U team/russell/make_output/apps/app_db.c U team/russell/make_output/apps/app_dial.c U team/russell/make_output/apps/app_dictate.c U team/russell/make_output/apps/app_directory.c U team/russell/make_output/apps/app_disa.c U team/russell/make_output/apps/app_exec.c U team/russell/make_output/apps/app_externalivr.c U team/russell/make_output/apps/app_festival.c U team/russell/make_output/apps/app_hasnewvoicemail.c U team/russell/make_output/apps/app_image.c U team/russell/make_output/apps/app_macro.c U team/russell/make_output/apps/app_meetme.c U team/russell/make_output/apps/app_mixmonitor.c U team/russell/make_output/apps/app_osplookup.c U team/russell/make_output/apps/app_page.c U team/russell/make_output/apps/app_parkandannounce.c U team/russell/make_output/apps/app_playback.c U team/russell/make_output/apps/app_privacy.c U team/russell/make_output/apps/app_queue.c U team/russell/make_output/apps/app_random.c U team/russell/make_output/apps/app_read.c U team/russell/make_output/apps/app_readfile.c U team/russell/make_output/apps/app_realtime.c U team/russell/make_output/apps/app_record.c U team/russell/make_output/apps/app_sayunixtime.c U team/russell/make_output/apps/app_senddtmf.c U team/russell/make_output/apps/app_sendtext.c U team/russell/make_output/apps/app_setcallerid.c U team/russell/make_output/apps/app_skel.c U team/russell/make_output/apps/app_sql_postgres.c U team/russell/make_output/apps/app_stack.c U team/russell/make_output/apps/app_talkdetect.c U team/russell/make_output/apps/app_transfer.c U team/russell/make_output/apps/app_url.c U team/russell/make_output/apps/app_userevent.c U team/russell/make_output/apps/app_verbose.c U team/russell/make_output/apps/app_voicemail.c U team/russell/make_output/apps/app_while.c U team/russell/make_output/apps/app_zapras.c U team/russell/make_output/channels/chan_agent.c U team/russell/make_output/channels/chan_iax2.c U team/russell/make_output/channels/chan_sip.c U team/russell/make_output/doc/README.variables U team/russell/make_output/funcs/func_cdr.c U team/russell/make_output/funcs/func_cut.c U team/russell/make_output/funcs/func_logic.c U team/russell/make_output/funcs/func_math.c U team/russell/make_output/funcs/func_md5.c U team/russell/make_output/funcs/func_odbc.c U team/russell/make_output/funcs/func_rand.c U team/russell/make_output/funcs/func_strings.c U team/russell/make_output/include/asterisk/astosp.h U team/russell/make_output/res/res_crypto.c U team/russell/make_output/res/res_features.c U team/russell/make_output/res/res_indications.c U team/russell/make_output/res/res_monitor.c U team/russell/make_output/res/res_musiconhold.c U team/russell/make_output/res/res_osp.c ------------------------------------------------------------------------ r8455 | russell | 2008-01-15 16:21:36 -0600 (Tue, 15 Jan 2008) | 122 lines Merged revisions 8401-8404,8407-8411,8413,8420-8422,8426,8428,8432,8436,8438,8443,8446-8447 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8401 | russell | 2006-01-21 15:20:06 -0500 (Sat, 21 Jan 2006) | 3 lines finish reverting my pass through the tree to remove checks of the result of ast_strdupa, this one is revision 8362 ................ r8402 | tilghman | 2006-01-21 15:32:17 -0500 (Sat, 21 Jan 2006) | 2 lines Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2) ................ r8403 | russell | 2006-01-21 15:57:06 -0500 (Sat, 21 Jan 2006) | 2 lines on this pass, only remove duplicate log messages ................ r8404 | russell | 2006-01-21 15:58:57 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8407 | russell | 2006-01-21 16:29:06 -0500 (Sat, 21 Jan 2006) | 2 lines clean up formatting to conform to coding guidelines and fix some typos (issue ASTERISK-6101) ................ r8408 | russell | 2006-01-21 16:50:09 -0500 (Sat, 21 Jan 2006) | 5 lines - conversion to allocation wrappers - get rid of some compiler warnings due to usused variables and const-ification - remove some unnecessary uses of malloc/strncpy/free and replace with ast_strdupa (based on the patch from issue ASTERISK-6115) ................ r8409 | russell | 2006-01-21 16:57:01 -0500 (Sat, 21 Jan 2006) | 2 lines oops, don't build app_sql_postgres by default ... ................ r8410 | russell | 2006-01-21 17:09:06 -0500 (Sat, 21 Jan 2006) | 5 lines - conversions to allocation wrappers - replace malloc/memset with ast_calloc - replace malloc/ast_copy_string with ast_strdup (based on patch from issue ASTERISK-6139) ................ r8411 | russell | 2006-01-21 18:05:19 -0500 (Sat, 21 Jan 2006) | 2 lines const-ify some fields in the ast_exten and ast_include structures (issue ASTERISK-6110) ................ r8413 | russell | 2006-01-21 18:17:52 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8420 | russell | 2006-01-21 21:06:33 -0500 (Sat, 21 Jan 2006) | 1 line ................ r8421 | russell | 2006-01-21 21:10:19 -0500 (Sat, 21 Jan 2006) | 3 lines prevent writing outside of the provided workspace when calculating a substring (issue ASTERISK-6111) ................ r8422 | russell | 2006-01-21 21:23:38 -0500 (Sat, 21 Jan 2006) | 2 lines add 'show channeltype' CLI command (issue ASTERISK-5992, with small modifications) ................ r8426 | tilghman | 2006-01-22 02:18:02 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6148 - Add PARKEDAT variable; also cleaned up application help to fit 80-column screen. ................ r8428 | tilghman | 2006-01-22 03:09:02 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6262 - New function STRPTIME ................ r8432 | bweschke | 2006-01-22 10:08:51 -0500 (Sun, 22 Jan 2006) | 2 lines Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953 ................ r8436 | tilghman | 2006-01-22 12:28:42 -0500 (Sun, 22 Jan 2006) | 2 lines Bug 6312 - Macro janitor ................ r8438 | russell | 2006-01-22 12:53:14 -0500 (Sun, 22 Jan 2006) | 10 lines Merged revisions 8437 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8437 | russell | 2006-01-22 12:47:13 -0500 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ ................ r8443 | russell | 2006-01-22 13:42:06 -0500 (Sun, 22 Jan 2006) | 2 lines eliminate some compiler warnings ................ r8446 | russell | 2006-01-22 14:04:37 -0500 (Sun, 22 Jan 2006) | 1 line ................ r8447 | russell | 2006-01-22 14:09:50 -0500 (Sun, 22 Jan 2006) | 2 lines fix memory leak from not freeing the list of queue members when freeing a queue ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8455 By: Digium Subversion (svnbot) 2008-01-15 16:22:02.000-0600 Repository: asterisk Revision: 8478 _U team/crichter/0.3.0/ U team/crichter/0.3.0/apps/app_queue.c U team/crichter/0.3.0/channel.c U team/crichter/0.3.0/channels/chan_sip.c U team/crichter/0.3.0/pbx.c ------------------------------------------------------------------------ r8478 | crichter | 2008-01-15 16:22:01 -0600 (Tue, 15 Jan 2008) | 47 lines Merged revisions 8394,8412,8414,8418,8429,8433,8437,8445 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8394 | tilghman | 2006-01-21 19:29:39 +0100 (Sa, 21 Jan 2006) | 2 lines Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded ........ r8412 | russell | 2006-01-22 00:17:06 +0100 (So, 22 Jan 2006) | 2 lines prevent the possibility of writing outside of the available workspace (issue ASTERISK-6111) ........ r8414 | russell | 2006-01-22 00:43:14 +0100 (So, 22 Jan 2006) | 2 lines temporarily revert substring fix pending the result of the discussion in issue ASTERISK-6111 ........ r8418 | russell | 2006-01-22 03:05:41 +0100 (So, 22 Jan 2006) | 3 lines add a modified fix to prevent writing outside of the provided workspace when calculating a substring (issue ASTERISK-6111) ........ r8429 | tilghman | 2006-01-22 09:52:49 +0100 (So, 22 Jan 2006) | 2 lines Bug 6281 - Cannot set more than a single header with SIPAddHeader ........ r8433 | bweschke | 2006-01-22 16:13:41 +0100 (So, 22 Jan 2006) | 3 lines Bug fix: Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953 ........ r8437 | russell | 2006-01-22 18:47:13 +0100 (So, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ r8445 | russell | 2006-01-22 20:03:53 +0100 (So, 22 Jan 2006) | 2 lines fix memory leak from not freeing the queue member list when freeing an old queue ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8478 By: Digium Subversion (svnbot) 2008-01-15 16:22:42.000-0600 Repository: asterisk Revision: 8515 _U team/oej/astum/ U team/oej/astum/Makefile U team/oej/astum/apps/app_queue.c U team/oej/astum/apps/app_random.c U team/oej/astum/apps/app_voicemail.c U team/oej/astum/channel.c U team/oej/astum/channels/chan_sip.c U team/oej/astum/configs/queues.conf.sample U team/oej/astum/funcs/func_db.c U team/oej/astum/funcs/func_rand.c U team/oej/astum/include/asterisk/astosp.h U team/oej/astum/manager.c U team/oej/astum/res/res_osp.c ------------------------------------------------------------------------ r8515 | oej | 2008-01-15 16:22:41 -0600 (Tue, 15 Jan 2008) | 123 lines Merged revisions 8438,8443,8446-8447,8463-8465,8471,8481-8483,8489-8490,8492-8493,8495,8500,8505,8514 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8438 | russell | 2006-01-22 18:53:14 +0100 (Sun, 22 Jan 2006) | 10 lines Merged revisions 8437 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8437 | russell | 2006-01-22 12:47:13 -0500 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ ................ r8443 | russell | 2006-01-22 19:42:06 +0100 (Sun, 22 Jan 2006) | 2 lines eliminate some compiler warnings ................ r8446 | russell | 2006-01-22 20:04:37 +0100 (Sun, 22 Jan 2006) | 1 line ................ r8447 | russell | 2006-01-22 20:09:50 +0100 (Sun, 22 Jan 2006) | 2 lines fix memory leak from not freeing the list of queue members when freeing a queue ................ r8463 | oej | 2006-01-23 13:19:16 +0100 (Mon, 23 Jan 2006) | 2 lines Remove javadoc doxygen format... ................ r8464 | oej | 2006-01-23 13:32:43 +0100 (Mon, 23 Jan 2006) | 2 lines Spelling fix undetected by kpfleming in rev 8150 ;-) ................ r8465 | oej | 2006-01-23 13:44:53 +0100 (Mon, 23 Jan 2006) | 2 lines Use doxygen for todo's! :-) ................ r8471 | oej | 2006-01-23 14:11:04 +0100 (Mon, 23 Jan 2006) | 3 lines - Adding some white space from my white space reservoir - Fixing some comment formatting (doxygen fix) ................ r8481 | oej | 2006-01-23 17:21:51 +0100 (Mon, 23 Jan 2006) | 2 lines Re-instate sip_addheader() while waiting for a dialplan function. (Issue 6317) ................ r8482 | oej | 2006-01-23 17:27:01 +0100 (Mon, 23 Jan 2006) | 2 lines Doxygen update ................ r8483 | oej | 2006-01-23 17:41:48 +0100 (Mon, 23 Jan 2006) | 3 lines - Debug output fixes - Whitespace fixes ................ r8489 | oej | 2006-01-23 18:08:19 +0100 (Mon, 23 Jan 2006) | 6 lines - Change "call" to "dialog" where use of "call" is confusing, since it may be a register transaction or a subscription. The word dialog is defined as "a peer-to-peer SIP relationship between two UAs that persist for some time" in RFC 3261. - Whitespace fixes - Debugging fixes (adding check of option_debug) ................ r8490 | oej | 2006-01-23 18:12:44 +0100 (Mon, 23 Jan 2006) | 3 lines Finally removing SIPDUMPER that hasn't been used for ages. If anyone needs this for some reason, please tell me and I'll put it back :-) ................ r8492 | oej | 2006-01-23 18:17:56 +0100 (Mon, 23 Jan 2006) | 2 lines Doxygen updates ................ r8493 | oej | 2006-01-23 18:19:03 +0100 (Mon, 23 Jan 2006) | 2 lines Remove more unused defines. ................ r8495 | mogorman | 2006-01-23 18:23:22 +0100 (Mon, 23 Jan 2006) | 3 lines changed some settings to app_args and some code cleaning patch 6267 ................ r8500 | oej | 2006-01-23 18:51:15 +0100 (Mon, 23 Jan 2006) | 2 lines Remove redundant default default/global settings from declaration, settings are done in reload_config() ................ r8505 | mogorman | 2006-01-23 19:07:12 +0100 (Mon, 23 Jan 2006) | 3 lines code clean up and macro implementation from bug 6247 ................ r8514 | oej | 2006-01-24 11:19:13 +0100 (Tue, 24 Jan 2006) | 9 lines - Adding doxygen comments - Changing default values set in reload_config to DEFAULT_ #defines to make it more clear what defaults are - Cleaning up global_ and default_ variable naming. - Moving variable and #defines together in the source, adding comments to explain sections Global_ is used for channel settings that does not apply to peers or users as defaults for their settings default_ is used both as a channel setting for unknown callers, as well as defaults for peers and users ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8515 By: Digium Subversion (svnbot) 2008-01-15 16:28:25.000-0600 Repository: asterisk Revision: 8891 _U team/oej/managerstuff/ D team/oej/managerstuff/ChangeLog U team/oej/managerstuff/apps/app_dial.c U team/oej/managerstuff/apps/app_festival.c U team/oej/managerstuff/apps/app_meetme.c U team/oej/managerstuff/apps/app_milliwatt.c U team/oej/managerstuff/apps/app_queue.c U team/oej/managerstuff/ast_expr2.c U team/oej/managerstuff/ast_expr2.fl U team/oej/managerstuff/ast_expr2.h U team/oej/managerstuff/ast_expr2.y U team/oej/managerstuff/ast_expr2f.c U team/oej/managerstuff/asterisk.c U team/oej/managerstuff/channel.c U team/oej/managerstuff/channels/chan_features.c U team/oej/managerstuff/channels/chan_iax2.c U team/oej/managerstuff/channels/chan_sip.c U team/oej/managerstuff/channels/chan_zap.c U team/oej/managerstuff/loader.c U team/oej/managerstuff/logger.c U team/oej/managerstuff/pbx.c U team/oej/managerstuff/res/res_features.c U team/oej/managerstuff/utils/astman.c ------------------------------------------------------------------------ r8891 | oej | 2008-01-15 16:28:24 -0600 (Tue, 15 Jan 2008) | 202 lines Merged revisions 8112,8122,8124,8134,8140,8162,8173,8194,8232,8242,8276,8281,8320,8347,8394,8412,8414,8418,8429,8433,8437,8445,8537,8562,8573,8588,8600,8608,8619,8632,8666,8677,8710,8729,8758,8785,8808 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8112 | kpfleming | 2006-01-17 00:51:37 +0100 (Tue, 17 Jan 2006) | 2 lines do rlimit check _after_ reading config file, in case 'dumpcore' is specified there ........ r8122 | kpfleming | 2006-01-17 14:11:55 +0100 (Tue, 17 Jan 2006) | 2 lines update CLI copyright notice ........ r8124 | mogorman | 2006-01-17 17:55:30 +0100 (Tue, 17 Jan 2006) | 3 lines Fixed code ordering of logger_init and queue_log_init bug 6263 ........ r8134 | mattf | 2006-01-17 19:29:57 +0100 (Tue, 17 Jan 2006) | 2 lines Backport of fix for ASTERISK-5936 ........ r8140 | mogorman | 2006-01-17 21:10:29 +0100 (Tue, 17 Jan 2006) | 3 lines Stop any generators running on a channel when festival is called as described in 5996 ........ r8162 | mogorman | 2006-01-18 01:47:04 +0100 (Wed, 18 Jan 2006) | 4 lines Changed order of autoload so that pbx_ comes before channels, and in doing so cause bug 6002 to not be an issue ........ r8173 | russell | 2006-01-18 03:49:21 +0100 (Wed, 18 Jan 2006) | 2 lines remove ChangeLog from the 1.2 branch. It will only be present in the tags. ........ r8194 | mogorman | 2006-01-18 22:02:06 +0100 (Wed, 18 Jan 2006) | 3 lines Solves issue with the login proccess in meetme patch from 6136 ........ r8232 | russell | 2006-01-19 05:17:45 +0100 (Thu, 19 Jan 2006) | 3 lines fix a seg fault due to assuming that space gets allocatted on the stack in the same order that we declare the variables (issue ASTERISK-6130) ........ r8242 | russell | 2006-01-19 05:56:48 +0100 (Thu, 19 Jan 2006) | 3 lines fix Message-Account header to use the ip address if the fromdomain isn't set (issue ASTERISK-6118) ........ r8276 | tilghman | 2006-01-19 20:14:37 +0100 (Thu, 19 Jan 2006) | 2 lines Bug 6072 - Memory leaks in the expression parser ........ r8281 | oej | 2006-01-19 20:40:28 +0100 (Thu, 19 Jan 2006) | 2 lines Enable "musicclass" setting for sip peers as per the config sample. ........ r8320 | mogorman | 2006-01-20 02:00:46 +0100 (Fri, 20 Jan 2006) | 3 lines solved problem with delayreject and iax trunking bug 4291 ........ r8347 | russell | 2006-01-20 19:34:42 +0100 (Fri, 20 Jan 2006) | 2 lines fix invalid value of prev_q (issue ASTERISK-6142) ........ r8394 | tilghman | 2006-01-21 19:29:39 +0100 (Sat, 21 Jan 2006) | 2 lines Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded ........ r8412 | russell | 2006-01-22 00:17:06 +0100 (Sun, 22 Jan 2006) | 2 lines prevent the possibility of writing outside of the available workspace (issue ASTERISK-6111) ........ r8414 | russell | 2006-01-22 00:43:14 +0100 (Sun, 22 Jan 2006) | 2 lines temporarily revert substring fix pending the result of the discussion in issue ASTERISK-6111 ........ r8418 | russell | 2006-01-22 03:05:41 +0100 (Sun, 22 Jan 2006) | 3 lines add a modified fix to prevent writing outside of the provided workspace when calculating a substring (issue ASTERISK-6111) ........ r8429 | tilghman | 2006-01-22 09:52:49 +0100 (Sun, 22 Jan 2006) | 2 lines Bug 6281 - Cannot set more than a single header with SIPAddHeader ........ r8433 | bweschke | 2006-01-22 16:13:41 +0100 (Sun, 22 Jan 2006) | 3 lines Bug fix: Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953 ........ r8437 | russell | 2006-01-22 18:47:13 +0100 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ r8445 | russell | 2006-01-22 20:03:53 +0100 (Sun, 22 Jan 2006) | 2 lines fix memory leak from not freeing the queue member list when freeing an old queue ........ r8537 | oej | 2006-01-24 14:15:13 +0100 (Tue, 24 Jan 2006) | 2 lines Issue ASTERISK-6148 - never send response to ACK. (Reported by whiskerp) ........ r8562 | oej | 2006-01-24 20:21:15 +0100 (Tue, 24 Jan 2006) | 2 lines Issue 6114: Don't hangup on BYE/ALSO with no channel. ........ r8573 | mattf | 2006-01-24 21:37:30 +0100 (Tue, 24 Jan 2006) | 2 lines Backport fix for ASTERISK-6071, hangup on polarity reversal ........ r8588 | kpfleming | 2006-01-24 23:32:09 +0100 (Tue, 24 Jan 2006) | 2 lines ensure that channel cannot become zombie after we check but before we try to start indications ........ r8600 | russell | 2006-01-24 23:55:32 +0100 (Tue, 24 Jan 2006) | 2 lines completely arbitrary whitespace change for testing something with svnmerge ... ........ r8608 | kpfleming | 2006-01-25 02:50:52 +0100 (Wed, 25 Jan 2006) | 2 lines ensure hangup cause code is handled properly when channel does not return a frame (issue ASTERISK-6186) ........ r8619 | russell | 2006-01-25 06:38:36 +0100 (Wed, 25 Jan 2006) | 2 lines don't leak almost 200 bytes for each new channel (issue ASTERISK-6170) ........ r8632 | oej | 2006-01-25 10:46:43 +0100 (Wed, 25 Jan 2006) | 2 lines Issue ASTERISK-6276 - the "timebomb" bug. Patch by Markster over GPRS ........ r8666 | russell | 2006-01-25 19:39:44 +0100 (Wed, 25 Jan 2006) | 2 lines fix memory leak (inspired by issue ASTERISK-6190) ........ r8677 | russell | 2006-01-25 20:14:43 +0100 (Wed, 25 Jan 2006) | 3 lines don't call ast_update_realtime with uninitialized variables if we get a registration with an expirey of 0 seconds (issue ASTERISK-6016) ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ r8729 | russell | 2006-01-26 20:42:35 +0100 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ r8758 | tilghman | 2006-01-27 01:52:12 +0100 (Fri, 27 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ r8808 | oej | 2006-01-28 14:52:15 +0100 (Sat, 28 Jan 2006) | 3 lines Issue 6182 - Don't remove scheduled event until it's really done. (reported by malverian) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8891 By: Digium Subversion (svnbot) 2008-01-15 16:28:31.000-0600 Repository: asterisk Revision: 8894 _U team/oej/moduletest/ U team/oej/moduletest/apps/app_dial.c U team/oej/moduletest/apps/app_queue.c U team/oej/moduletest/ast_expr2.c U team/oej/moduletest/ast_expr2.h U team/oej/moduletest/ast_expr2f.c U team/oej/moduletest/asterisk.c U team/oej/moduletest/channel.c U team/oej/moduletest/channels/chan_features.c U team/oej/moduletest/channels/chan_iax2.c U team/oej/moduletest/channels/chan_sip.c U team/oej/moduletest/channels/chan_zap.c U team/oej/moduletest/pbx.c U team/oej/moduletest/utils/astman.c ------------------------------------------------------------------------ r8894 | oej | 2008-01-15 16:28:30 -0600 (Tue, 15 Jan 2008) | 135 lines Merged revisions 8320,8347,8394,8412,8414,8418,8429,8433,8437,8445,8537,8562,8573,8588,8600,8608,8619,8632,8666,8677,8710,8729,8758,8785,8808 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8320 | mogorman | 2006-01-20 02:00:46 +0100 (Fri, 20 Jan 2006) | 3 lines solved problem with delayreject and iax trunking bug 4291 ........ r8347 | russell | 2006-01-20 19:34:42 +0100 (Fri, 20 Jan 2006) | 2 lines fix invalid value of prev_q (issue ASTERISK-6142) ........ r8394 | tilghman | 2006-01-21 19:29:39 +0100 (Sat, 21 Jan 2006) | 2 lines Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded ........ r8412 | russell | 2006-01-22 00:17:06 +0100 (Sun, 22 Jan 2006) | 2 lines prevent the possibility of writing outside of the available workspace (issue ASTERISK-6111) ........ r8414 | russell | 2006-01-22 00:43:14 +0100 (Sun, 22 Jan 2006) | 2 lines temporarily revert substring fix pending the result of the discussion in issue ASTERISK-6111 ........ r8418 | russell | 2006-01-22 03:05:41 +0100 (Sun, 22 Jan 2006) | 3 lines add a modified fix to prevent writing outside of the provided workspace when calculating a substring (issue ASTERISK-6111) ........ r8429 | tilghman | 2006-01-22 09:52:49 +0100 (Sun, 22 Jan 2006) | 2 lines Bug 6281 - Cannot set more than a single header with SIPAddHeader ........ r8433 | bweschke | 2006-01-22 16:13:41 +0100 (Sun, 22 Jan 2006) | 3 lines Bug fix: Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953 ........ r8437 | russell | 2006-01-22 18:47:13 +0100 (Sun, 22 Jan 2006) | 2 lines fix MixMonitor crash (issue ASTERISK-6161, probably others) ........ r8445 | russell | 2006-01-22 20:03:53 +0100 (Sun, 22 Jan 2006) | 2 lines fix memory leak from not freeing the queue member list when freeing an old queue ........ r8537 | oej | 2006-01-24 14:15:13 +0100 (Tue, 24 Jan 2006) | 2 lines Issue ASTERISK-6148 - never send response to ACK. (Reported by whiskerp) ........ r8562 | oej | 2006-01-24 20:21:15 +0100 (Tue, 24 Jan 2006) | 2 lines Issue 6114: Don't hangup on BYE/ALSO with no channel. ........ r8573 | mattf | 2006-01-24 21:37:30 +0100 (Tue, 24 Jan 2006) | 2 lines Backport fix for ASTERISK-6071, hangup on polarity reversal ........ r8588 | kpfleming | 2006-01-24 23:32:09 +0100 (Tue, 24 Jan 2006) | 2 lines ensure that channel cannot become zombie after we check but before we try to start indications ........ r8600 | russell | 2006-01-24 23:55:32 +0100 (Tue, 24 Jan 2006) | 2 lines completely arbitrary whitespace change for testing something with svnmerge ... ........ r8608 | kpfleming | 2006-01-25 02:50:52 +0100 (Wed, 25 Jan 2006) | 2 lines ensure hangup cause code is handled properly when channel does not return a frame (issue ASTERISK-6186) ........ r8619 | russell | 2006-01-25 06:38:36 +0100 (Wed, 25 Jan 2006) | 2 lines don't leak almost 200 bytes for each new channel (issue ASTERISK-6170) ........ r8632 | oej | 2006-01-25 10:46:43 +0100 (Wed, 25 Jan 2006) | 2 lines Issue ASTERISK-6276 - the "timebomb" bug. Patch by Markster over GPRS ........ r8666 | russell | 2006-01-25 19:39:44 +0100 (Wed, 25 Jan 2006) | 2 lines fix memory leak (inspired by issue ASTERISK-6190) ........ r8677 | russell | 2006-01-25 20:14:43 +0100 (Wed, 25 Jan 2006) | 3 lines don't call ast_update_realtime with uninitialized variables if we get a registration with an expirey of 0 seconds (issue ASTERISK-6016) ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ r8729 | russell | 2006-01-26 20:42:35 +0100 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ r8758 | tilghman | 2006-01-27 01:52:12 +0100 (Fri, 27 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ r8808 | oej | 2006-01-28 14:52:15 +0100 (Sat, 28 Jan 2006) | 3 lines Issue 6182 - Don't remove scheduled event until it's really done. (reported by malverian) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8894 | ||