Asterisk
  1. Asterisk
  2. ASTERISK-6194

PATCH: Set IP TOS separately for SIP packets, RTP audio packets, and RTP video packets

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      6355
    • Regression:
      No

      Description

      Currently, Asterisk lets you set the same IP TOS for all packets that a SIP channel could generate (SIP call signalling packets, RTP audio packets, and RTP video packets). However, different types of packets have different quality of
      service requirements. For more information, see the "Enterprise QoS Solution Reference Network Design Guide" from Cisco:

      http://www.cisco.com/application/pdf/en/us/guest/netsol/ns432/c649/ccmigration_09186a008049b062.pdf

                • ADDITIONAL INFORMATION ******

      Attached are patches for branch/1.2 and trunk that allow chan_sip to set different IP TOS values for the different kids of packets.

      1. qos-1.2-patch.txt
        7 kB
      2. qos-trunk-patch.txt
        8 kB
      3. qos-trunk-patch-2.txt
        10 kB
      4. qos-trunk-patch-8938.txt
        16 kB

        Activity

        Hide
        Olle Johansson added a comment -

        The code is in the /team/oej/iptos branch.

        Show
        Olle Johansson added a comment - The code is in the /team/oej/iptos branch.
        Hide
        Jared Smith added a comment -

        I've tested this as part of Olle's test-this-branch branch, and it looks great! I only have 2 minor concerns:

        1) The debug messages point to the wrong README file (README.tos instead of ip-tos.txt)
        2) If I issue an "IAX2 reload" from the Asterisk CLI, I get the following debug message, even though tos isn't set to lowdelay in iax.conf:

        Mar 13 12:03:38 WARNING[32280]: acl.c:262 ast_str2tos: tos value lowdelay is deprecated. See doc/README.tos for more information.

        Other than those two little things, I think this is probably ready for trunk (in my humble opinion).

        Show
        Jared Smith added a comment - I've tested this as part of Olle's test-this-branch branch, and it looks great! I only have 2 minor concerns: 1) The debug messages point to the wrong README file (README.tos instead of ip-tos.txt) 2) If I issue an "IAX2 reload" from the Asterisk CLI, I get the following debug message, even though tos isn't set to lowdelay in iax.conf: Mar 13 12:03:38 WARNING [32280] : acl.c:262 ast_str2tos: tos value lowdelay is deprecated. See doc/README.tos for more information. Other than those two little things, I think this is probably ready for trunk (in my humble opinion).
        Hide
        Olle Johansson added a comment -

        Committed to svn trunk revision 15435

        • Changed the settings to IANA registered types
        • Made a conversion table to/from string to value

        Thanks for your work!

        Show
        Olle Johansson added a comment - Committed to svn trunk revision 15435 Changed the settings to IANA registered types Made a conversion table to/from string to value Thanks for your work!
        Hide
        Olle Johansson added a comment -
        • removing branch "team/oej/iptos"
        Show
        Olle Johansson added a comment - removing branch "team/oej/iptos"
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 8973

        A team/oej/iptos/

        ------------------------------------------------------------------------
        r8973 | oej | 2008-01-15 16:29:47 -0600 (Tue, 15 Jan 2008) | 2 lines

        Issue ASTERISK-6194 - update of IP TOS settings for IAX and SIP

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=8973

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 8973 A team/oej/iptos/ ------------------------------------------------------------------------ r8973 | oej | 2008-01-15 16:29:47 -0600 (Tue, 15 Jan 2008) | 2 lines Issue ASTERISK-6194 - update of IP TOS settings for IAX and SIP ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8973

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development