[Home]

Summary:ASTERISK-06203: Unreliable inbound DTMF signalling on E&M trunks.
Reporter:Justin Unger (justinu)Labels:
Date Opened:2006-01-26 11:57:20.000-0600Date Closed:2008-01-15 16:29:55.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Interoperability
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:If chan_zap channels are configured with E&M signalling, inbound DTMF signalling is unreliable.

A simple patch to chan_zap.c fixes this bug:

diff -uPr asterisk-1.2.1/channels/chan_zap.c asterisk-1.2.1a/channels/chan_zap.c
--- asterisk-1.2.1/channels/chan_zap.c  2005-11-29 10:24:39.000000000 -0800
+++ asterisk-1.2.1a/channels/chan_zap.c 2006-01-26 10:40:37.000000000 -0800
@@ -5278,7 +5278,11 @@
                       else
                               ast_dsp_digitmode(p->dsp,DSP_DIGITMODE_DTMF | p->dtmfrelax);
               }
+               /* This is broken
               dtmfbuf[0] = 0;
+               */
+               memset(dtmfbuf, 0, 300);
+
               /* Wait for the first digit only if immediate=no */
               if (!p->immediate)
                       /* Wait for the first digit (up to 5 seconds). */



Comments:By: Justin Unger (justinu) 2006-01-26 11:59:09.000-0600

Oops, somehow this got under SIP. It should be under Zaptel.

By: Russell Bryant (russell) 2006-01-26 12:44:33.000-0600

fixed in the 1.2 branch and trunk in revisions 8729 and 8730, thanks!

By: Digium Subversion (svnbot) 2008-01-15 16:26:03.000-0600

Repository: asterisk
Revision: 8729

U   branches/1.2/channels/chan_zap.c

------------------------------------------------------------------------
r8729 | russell | 2008-01-15 16:26:02 -0600 (Tue, 15 Jan 2008) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8729

By: Digium Subversion (svnbot) 2008-01-15 16:26:04.000-0600

Repository: asterisk
Revision: 8730

_U  trunk/
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r8730 | russell | 2008-01-15 16:26:03 -0600 (Tue, 15 Jan 2008) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8730

By: Digium Subversion (svnbot) 2008-01-15 16:28:22.000-0600

Repository: asterisk
Revision: 8890

_U  team/oej/jitterbuffer/
U   team/oej/jitterbuffer/Makefile
U   team/oej/jitterbuffer/UPGRADE.txt
U   team/oej/jitterbuffer/apps/app_dial.c
U   team/oej/jitterbuffer/apps/app_externalivr.c
U   team/oej/jitterbuffer/apps/app_meetme.c
U   team/oej/jitterbuffer/ast_expr2.c
U   team/oej/jitterbuffer/ast_expr2.h
U   team/oej/jitterbuffer/ast_expr2f.c
U   team/oej/jitterbuffer/channel.c
U   team/oej/jitterbuffer/channels/chan_agent.c
U   team/oej/jitterbuffer/channels/chan_features.c
U   team/oej/jitterbuffer/channels/chan_iax2.c
U   team/oej/jitterbuffer/channels/chan_sip.c
U   team/oej/jitterbuffer/channels/chan_zap.c
U   team/oej/jitterbuffer/funcs/func_md5.c
U   team/oej/jitterbuffer/include/asterisk/channel.h
U   team/oej/jitterbuffer/include/asterisk/frame.h
U   team/oej/jitterbuffer/res/Makefile

------------------------------------------------------------------------
r8890 | oej | 2008-01-15 16:28:22 -0600 (Tue, 15 Jan 2008) | 188 lines

Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8890

By: Digium Subversion (svnbot) 2008-01-15 16:28:25.000-0600

Repository: asterisk
Revision: 8891

_U  team/oej/managerstuff/
D   team/oej/managerstuff/ChangeLog
U   team/oej/managerstuff/apps/app_dial.c
U   team/oej/managerstuff/apps/app_festival.c
U   team/oej/managerstuff/apps/app_meetme.c
U   team/oej/managerstuff/apps/app_milliwatt.c
U   team/oej/managerstuff/apps/app_queue.c
U   team/oej/managerstuff/ast_expr2.c
U   team/oej/managerstuff/ast_expr2.fl
U   team/oej/managerstuff/ast_expr2.h
U   team/oej/managerstuff/ast_expr2.y
U   team/oej/managerstuff/ast_expr2f.c
U   team/oej/managerstuff/asterisk.c
U   team/oej/managerstuff/channel.c
U   team/oej/managerstuff/channels/chan_features.c
U   team/oej/managerstuff/channels/chan_iax2.c
U   team/oej/managerstuff/channels/chan_sip.c
U   team/oej/managerstuff/channels/chan_zap.c
U   team/oej/managerstuff/loader.c
U   team/oej/managerstuff/logger.c
U   team/oej/managerstuff/pbx.c
U   team/oej/managerstuff/res/res_features.c
U   team/oej/managerstuff/utils/astman.c

------------------------------------------------------------------------
r8891 | oej | 2008-01-15 16:28:24 -0600 (Tue, 15 Jan 2008) | 202 lines

Merged revisions 8112,8122,8124,8134,8140,8162,8173,8194,8232,8242,8276,8281,8320,8347,8394,8412,8414,8418,8429,8433,8437,8445,8537,8562,8573,8588,8600,8608,8619,8632,8666,8677,8710,8729,8758,8785,8808 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8112 | kpfleming | 2006-01-17 00:51:37 +0100 (Tue, 17 Jan 2006) | 2 lines

do rlimit check _after_ reading config file, in case 'dumpcore' is specified there

........
r8122 | kpfleming | 2006-01-17 14:11:55 +0100 (Tue, 17 Jan 2006) | 2 lines

update CLI copyright notice

........
r8124 | mogorman | 2006-01-17 17:55:30 +0100 (Tue, 17 Jan 2006) | 3 lines

Fixed code ordering of logger_init and queue_log_init
bug 6263

........
r8134 | mattf | 2006-01-17 19:29:57 +0100 (Tue, 17 Jan 2006) | 2 lines

Backport of fix for ASTERISK-5936

........
r8140 | mogorman | 2006-01-17 21:10:29 +0100 (Tue, 17 Jan 2006) | 3 lines

Stop any generators running on a channel when
festival is called as described in 5996

........
r8162 | mogorman | 2006-01-18 01:47:04 +0100 (Wed, 18 Jan 2006) | 4 lines

Changed order of autoload so that pbx_ comes before
channels, and in doing so cause bug 6002 to not
be an issue

........
r8173 | russell | 2006-01-18 03:49:21 +0100 (Wed, 18 Jan 2006) | 2 lines

remove ChangeLog from the 1.2 branch.  It will only be present in the tags.

........
r8194 | mogorman | 2006-01-18 22:02:06 +0100 (Wed, 18 Jan 2006) | 3 lines

Solves issue with the login proccess in meetme
patch from 6136

........
r8232 | russell | 2006-01-19 05:17:45 +0100 (Thu, 19 Jan 2006) | 3 lines

fix a seg fault due to assuming that space gets allocatted on the stack in the
same order that we declare the variables (issue ASTERISK-6130)

........
r8242 | russell | 2006-01-19 05:56:48 +0100 (Thu, 19 Jan 2006) | 3 lines

fix Message-Account header to use the ip address if the fromdomain
isn't set (issue ASTERISK-6118)

........
r8276 | tilghman | 2006-01-19 20:14:37 +0100 (Thu, 19 Jan 2006) | 2 lines

Bug 6072 - Memory leaks in the expression parser

........
r8281 | oej | 2006-01-19 20:40:28 +0100 (Thu, 19 Jan 2006) | 2 lines

Enable "musicclass" setting for sip peers as per the config sample.

........
r8320 | mogorman | 2006-01-20 02:00:46 +0100 (Fri, 20 Jan 2006) | 3 lines

solved problem with delayreject and iax trunking
bug 4291

........
r8347 | russell | 2006-01-20 19:34:42 +0100 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........
r8394 | tilghman | 2006-01-21 19:29:39 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded

........
r8412 | russell | 2006-01-22 00:17:06 +0100 (Sun, 22 Jan 2006) | 2 lines

prevent the possibility of writing outside of the available workspace (issue ASTERISK-6111)

........
r8414 | russell | 2006-01-22 00:43:14 +0100 (Sun, 22 Jan 2006) | 2 lines

temporarily revert substring fix pending the result of the discussion in issue ASTERISK-6111

........
r8418 | russell | 2006-01-22 03:05:41 +0100 (Sun, 22 Jan 2006) | 3 lines

add a modified fix to prevent writing outside of the provided workspace when
calculating a substring (issue ASTERISK-6111)

........
r8429 | tilghman | 2006-01-22 09:52:49 +0100 (Sun, 22 Jan 2006) | 2 lines

Bug 6281 - Cannot set more than a single header with SIPAddHeader

........
r8433 | bweschke | 2006-01-22 16:13:41 +0100 (Sun, 22 Jan 2006) | 3 lines

Bug fix: Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953


........
r8437 | russell | 2006-01-22 18:47:13 +0100 (Sun, 22 Jan 2006) | 2 lines

fix MixMonitor crash (issue ASTERISK-6161, probably others)

........
r8445 | russell | 2006-01-22 20:03:53 +0100 (Sun, 22 Jan 2006) | 2 lines

fix memory leak from not freeing the queue member list when freeing an old queue

........
r8537 | oej | 2006-01-24 14:15:13 +0100 (Tue, 24 Jan 2006) | 2 lines

Issue ASTERISK-6148 - never send response to ACK. (Reported by whiskerp)

........
r8562 | oej | 2006-01-24 20:21:15 +0100 (Tue, 24 Jan 2006) | 2 lines

Issue 6114: Don't hangup on BYE/ALSO with no channel.

........
r8573 | mattf | 2006-01-24 21:37:30 +0100 (Tue, 24 Jan 2006) | 2 lines

Backport fix for ASTERISK-6071, hangup on polarity reversal

........
r8588 | kpfleming | 2006-01-24 23:32:09 +0100 (Tue, 24 Jan 2006) | 2 lines

ensure that channel cannot become zombie after we check but before we try to start indications

........
r8600 | russell | 2006-01-24 23:55:32 +0100 (Tue, 24 Jan 2006) | 2 lines

completely arbitrary whitespace change for testing something with svnmerge ...

........
r8608 | kpfleming | 2006-01-25 02:50:52 +0100 (Wed, 25 Jan 2006) | 2 lines

ensure hangup cause code is handled properly when channel does not return a frame (issue ASTERISK-6186)

........
r8619 | russell | 2006-01-25 06:38:36 +0100 (Wed, 25 Jan 2006) | 2 lines

don't leak almost 200 bytes for each new channel (issue ASTERISK-6170)

........
r8632 | oej | 2006-01-25 10:46:43 +0100 (Wed, 25 Jan 2006) | 2 lines

Issue ASTERISK-6276 - the "timebomb" bug. Patch by Markster over GPRS

........
r8666 | russell | 2006-01-25 19:39:44 +0100 (Wed, 25 Jan 2006) | 2 lines

fix memory leak (inspired by issue ASTERISK-6190)

........
r8677 | russell | 2006-01-25 20:14:43 +0100 (Wed, 25 Jan 2006) | 3 lines

don't call ast_update_realtime with uninitialized variables if we get a
registration with an expirey of 0 seconds (issue ASTERISK-6016)

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........
r8729 | russell | 2006-01-26 20:42:35 +0100 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........
r8758 | tilghman | 2006-01-27 01:52:12 +0100 (Fri, 27 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........
r8808 | oej | 2006-01-28 14:52:15 +0100 (Sat, 28 Jan 2006) | 3 lines

Issue 6182 - Don't remove scheduled event until it's really done.
(reported by malverian)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8891

By: Digium Subversion (svnbot) 2008-01-15 16:28:29.000-0600

Repository: asterisk
Revision: 8893

_U  team/oej/multiparking/
U   team/oej/multiparking/Makefile
U   team/oej/multiparking/UPGRADE.txt
U   team/oej/multiparking/apps/app_dial.c
U   team/oej/multiparking/apps/app_externalivr.c
U   team/oej/multiparking/apps/app_meetme.c
U   team/oej/multiparking/ast_expr2.c
U   team/oej/multiparking/ast_expr2.h
U   team/oej/multiparking/ast_expr2f.c
U   team/oej/multiparking/channel.c
U   team/oej/multiparking/channels/chan_agent.c
U   team/oej/multiparking/channels/chan_features.c
U   team/oej/multiparking/channels/chan_iax2.c
U   team/oej/multiparking/channels/chan_sip.c
U   team/oej/multiparking/channels/chan_zap.c
U   team/oej/multiparking/funcs/func_md5.c
U   team/oej/multiparking/include/asterisk/channel.h
U   team/oej/multiparking/include/asterisk/frame.h
U   team/oej/multiparking/res/Makefile

------------------------------------------------------------------------
r8893 | oej | 2008-01-15 16:28:28 -0600 (Tue, 15 Jan 2008) | 188 lines

Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8893

By: Digium Subversion (svnbot) 2008-01-15 16:28:31.000-0600

Repository: asterisk
Revision: 8894

_U  team/oej/moduletest/
U   team/oej/moduletest/apps/app_dial.c
U   team/oej/moduletest/apps/app_queue.c
U   team/oej/moduletest/ast_expr2.c
U   team/oej/moduletest/ast_expr2.h
U   team/oej/moduletest/ast_expr2f.c
U   team/oej/moduletest/asterisk.c
U   team/oej/moduletest/channel.c
U   team/oej/moduletest/channels/chan_features.c
U   team/oej/moduletest/channels/chan_iax2.c
U   team/oej/moduletest/channels/chan_sip.c
U   team/oej/moduletest/channels/chan_zap.c
U   team/oej/moduletest/pbx.c
U   team/oej/moduletest/utils/astman.c

------------------------------------------------------------------------
r8894 | oej | 2008-01-15 16:28:30 -0600 (Tue, 15 Jan 2008) | 135 lines

Merged revisions 8320,8347,8394,8412,8414,8418,8429,8433,8437,8445,8537,8562,8573,8588,8600,8608,8619,8632,8666,8677,8710,8729,8758,8785,8808 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8320 | mogorman | 2006-01-20 02:00:46 +0100 (Fri, 20 Jan 2006) | 3 lines

solved problem with delayreject and iax trunking
bug 4291

........
r8347 | russell | 2006-01-20 19:34:42 +0100 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........
r8394 | tilghman | 2006-01-21 19:29:39 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded

........
r8412 | russell | 2006-01-22 00:17:06 +0100 (Sun, 22 Jan 2006) | 2 lines

prevent the possibility of writing outside of the available workspace (issue ASTERISK-6111)

........
r8414 | russell | 2006-01-22 00:43:14 +0100 (Sun, 22 Jan 2006) | 2 lines

temporarily revert substring fix pending the result of the discussion in issue ASTERISK-6111

........
r8418 | russell | 2006-01-22 03:05:41 +0100 (Sun, 22 Jan 2006) | 3 lines

add a modified fix to prevent writing outside of the provided workspace when
calculating a substring (issue ASTERISK-6111)

........
r8429 | tilghman | 2006-01-22 09:52:49 +0100 (Sun, 22 Jan 2006) | 2 lines

Bug 6281 - Cannot set more than a single header with SIPAddHeader

........
r8433 | bweschke | 2006-01-22 16:13:41 +0100 (Sun, 22 Jan 2006) | 3 lines

Bug fix: Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953


........
r8437 | russell | 2006-01-22 18:47:13 +0100 (Sun, 22 Jan 2006) | 2 lines

fix MixMonitor crash (issue ASTERISK-6161, probably others)

........
r8445 | russell | 2006-01-22 20:03:53 +0100 (Sun, 22 Jan 2006) | 2 lines

fix memory leak from not freeing the queue member list when freeing an old queue

........
r8537 | oej | 2006-01-24 14:15:13 +0100 (Tue, 24 Jan 2006) | 2 lines

Issue ASTERISK-6148 - never send response to ACK. (Reported by whiskerp)

........
r8562 | oej | 2006-01-24 20:21:15 +0100 (Tue, 24 Jan 2006) | 2 lines

Issue 6114: Don't hangup on BYE/ALSO with no channel.

........
r8573 | mattf | 2006-01-24 21:37:30 +0100 (Tue, 24 Jan 2006) | 2 lines

Backport fix for ASTERISK-6071, hangup on polarity reversal

........
r8588 | kpfleming | 2006-01-24 23:32:09 +0100 (Tue, 24 Jan 2006) | 2 lines

ensure that channel cannot become zombie after we check but before we try to start indications

........
r8600 | russell | 2006-01-24 23:55:32 +0100 (Tue, 24 Jan 2006) | 2 lines

completely arbitrary whitespace change for testing something with svnmerge ...

........
r8608 | kpfleming | 2006-01-25 02:50:52 +0100 (Wed, 25 Jan 2006) | 2 lines

ensure hangup cause code is handled properly when channel does not return a frame (issue ASTERISK-6186)

........
r8619 | russell | 2006-01-25 06:38:36 +0100 (Wed, 25 Jan 2006) | 2 lines

don't leak almost 200 bytes for each new channel (issue ASTERISK-6170)

........
r8632 | oej | 2006-01-25 10:46:43 +0100 (Wed, 25 Jan 2006) | 2 lines

Issue ASTERISK-6276 - the "timebomb" bug. Patch by Markster over GPRS

........
r8666 | russell | 2006-01-25 19:39:44 +0100 (Wed, 25 Jan 2006) | 2 lines

fix memory leak (inspired by issue ASTERISK-6190)

........
r8677 | russell | 2006-01-25 20:14:43 +0100 (Wed, 25 Jan 2006) | 3 lines

don't call ast_update_realtime with uninitialized variables if we get a
registration with an expirey of 0 seconds (issue ASTERISK-6016)

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........
r8729 | russell | 2006-01-26 20:42:35 +0100 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........
r8758 | tilghman | 2006-01-27 01:52:12 +0100 (Fri, 27 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........
r8808 | oej | 2006-01-28 14:52:15 +0100 (Sat, 28 Jan 2006) | 3 lines

Issue 6182 - Don't remove scheduled event until it's really done.
(reported by malverian)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8894

By: Digium Subversion (svnbot) 2008-01-15 16:29:55.000-0600

Repository: asterisk
Revision: 8981

_U  team/oej/astum/
U   team/oej/astum/.cleancount
U   team/oej/astum/Makefile
U   team/oej/astum/UPGRADE.txt
U   team/oej/astum/apps/app_dial.c
U   team/oej/astum/apps/app_externalivr.c
U   team/oej/astum/apps/app_meetme.c
U   team/oej/astum/ast_expr2.c
U   team/oej/astum/ast_expr2.h
U   team/oej/astum/ast_expr2f.c
U   team/oej/astum/channel.c
U   team/oej/astum/channels/chan_agent.c
U   team/oej/astum/channels/chan_features.c
U   team/oej/astum/channels/chan_iax2.c
U   team/oej/astum/channels/chan_sip.c
U   team/oej/astum/channels/chan_zap.c
U   team/oej/astum/configs/sip.conf.sample
U   team/oej/astum/funcs/func_md5.c
U   team/oej/astum/include/asterisk/channel.h
U   team/oej/astum/include/asterisk/frame.h
U   team/oej/astum/include/asterisk/stringfields.h
U   team/oej/astum/pbx.c
U   team/oej/astum/res/Makefile
U   team/oej/astum/utils.c

------------------------------------------------------------------------
r8981 | oej | 2008-01-15 16:29:55 -0600 (Tue, 15 Jan 2008) | 277 lines

Merged revisions 8687,8697,8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883,8896,8906,8919,8925-8926,8932,8938,8948-8949,8961,8976 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8687 | russell | 2006-01-25 21:02:12 +0100 (Wed, 25 Jan 2006) | 2 lines

use arg parsing macros for WaitExten and Background (issue ASTERISK-6028)

................
r8697 | kpfleming | 2006-01-26 05:00:05 +0100 (Thu, 26 Jan 2006) | 4 lines

string field manager improvements:
use multiple memory blocks, instead of realloc(), ensuring that field pointers will never become invalid or change
don't run vs(n)printf twice when doing a field build unless required

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................
r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines

Document installation changes for BSD users.

................
r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines

Merged revisions 8905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines

disable buggy PRI user-user code until it can be fixed

........

................
r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines

Issue ASTERISK-5643
- simplification of check_auth
- constifications
- whitespace changes
Rizzo's patch with some changes

................
r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines

Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik.
Patch inspired by, but not the patch in the bug tracker.

................
r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines

Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted

................
r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines

- Doxygen and comments updates
- Moving structure declarations to top of file with the rest
- Adding some forward declarations for RTP interface functions

(All these changes to position in file are in preparation for splitting chan_sip up
into several files at some point in the future)


................
r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines

reverting  blocks 9 and 10 from revision 7547
fixes bug 6080

................
r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines

increment for recent ast_channel change

................
r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines

add a note to hopefully decrease the chance that someone forgets to increment
.cleancount after changing the ast_channel structure

................
r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines

Yes Virginia, Zaptel does support native ALAW

................
r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines

- Change "prefs" to "default_prefs" and move declaration to "default" group
- Add doxygen comments

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8981