[Home]

Summary:ASTERISK-06769: [patch][post 1.4] Change default return extension after parking timeout
Reporter:dimitripietro (dimitripietro)Labels:
Date Opened:2006-04-13 00:26:26Date Closed:2006-10-31 18:12:50.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cli_diver_r3.txt
( 1) Cli_FirstTry_24-04-06_v2
( 2) M6953_rev2.txt
( 3) M6953_rev3.txt
( 4) M6953.txt
( 5) parkingslot_cli.txt
( 6) res_features.c.diff
Description:I'm not a programmer, but the thing that make me crazy is that it's not possible to decide where the call will be routed after timeout from the parking slot. If anyone want to take a look.

Thx
Comments:By: Joshua C. Colp (jcolp) 2006-04-15 19:59:34

You should give more thought into your bug report. How would it be specified for example? Dialplan variable?

By: Russell Bryant (russell) 2006-04-16 02:47:58

First of all, I would like to note that this is absolutely *not* a bug, so it's not really an appropriate report for the bug tracker.

However, while we're on the topic, I didn't really like the way this was changed when it was done quite a while ago ...

In Asterisk 1.0, if a parked call timed out, it would continue at the "s" extension in the context from which it was parked.

Before Asterisk 1.2 was released, this was changed such that it remembers the channel name that parked the call and tries to return there.  Unfortunately, this definitely can't work in all cases.

What I would like to propose is to allow the user to configure the behavior to be either the way it is now, where it attempts to go back to the channel that parked the call, or allow the timeout extension and timeout context to be configurable.  I'll try to code this up this week sometime if it sounds good.

By: dimitripietro (dimitripietro) 2006-04-16 23:03:39

Russel,

I know this is not a bug. Before to post, I red the bug tracker guideline. It's written that new idea/feature request are welcome. Did anyone still need me to post some example and some copy/paste of the CLI ?

David



By: Clod Patry (junky) 2006-04-20 21:30:36

russell: dimitripietro  was in an AMUG meeting (Asterisk Montreal User Group).
He explains me what he wants exactly.

After a call is parked, after the timeout, it returns automatiquely to the person that place him. He wants to change that behavior in a way that will allow to say, after a timeout, the callee to a specific extension instead of the caller.

Plus, he mentionned, if the caller is already on phone (all lines busy), after the timeout, on the callback to the caller, the channel will hangup.

just catch me this week-end, on IRC, to discuss about it.

By: Clod Patry (junky) 2006-04-23 08:44:12

russell:
is it why we see exten s, and priority 1 when doing a show parkedcalls, even if that exten has nothing to do there.
After the parkedtimeout, it will callback to the person which has place SIP/19 in the Park() , which could be seen via the show dialplan park-dial.

polux*CLI> show parkedcalls
Num                   Channel (Context         Extension    Pri ) Timeout
701               SIP/19-b208 (polycom         s            1   )     30s
1 parked call.

If the "show parkedcalls" has to change, let me know.



What did you have in mind related to this: something like:
comebacktoorigin = no           ; If set to no, the parkedcalls will be redirect to exten t, in the context where it has been placed
                               ; default is yes

in the features.conf?

By: Russell Bryant (russell) 2006-04-23 08:50:36

Yeah, that is what I had in mind.  However, I'd rather it return to "s" instead of "t", because that was the original behavior.  It could be taken a step further and be made configurable, though.

By: Clod Patry (junky) 2006-04-23 08:52:42

i will redirect 'em to s for now, if comebacktoorigin is set to no.
If set to yes, will keep the same behavior.

By: Clod Patry (junky) 2006-04-23 09:26:56

dimitripietro: let me know if it works fine for ya.

By: dimitripietro (dimitripietro) 2006-04-23 20:47:32

Thanks Junky,
You did it very fast, but could you please tell how to add the patch to Asterisk and also on which version I should use this patch?

I think it would be a better idea if when comebacktoorigin is set to no to return to another extension than "s", something like "p" maybe. Because, after a timeout, I want to be able to make the difference between a new call incoming into the context and a call coming back from a parking slot. What do you thing ?

As soon as a know how to patch, I will test it.

Thx

By: Clod Patry (junky) 2006-04-23 21:04:00

Please see: http://www.asterisk.org/developers/Patch_Howto
That patch is with latest trunk.

Your idea is not bad at all, like russell said earlier in this thread, maybe we could define  timeout c_e_p too.

By: dimitripietro (dimitripietro) 2006-04-24 00:01:23

Junky,

I just posted a copy of my CLI but ignore it or delete it. I have to get my new hardphone before I can hard test the patch.

Dimitripietro

By: dimitripietro (dimitripietro) 2006-04-24 00:58:42

I tested it with softphone. After the timeout, instead of dialing the original person directly by using some kind of park-dial context, the call is now coming into the right context(internal in my case) but instead of going to the s extension, it is routed to the same extension that parked the call originaly and to the last priority executed before being parked this mean the dial priority.

There is a major diffence, before the original caller was contacted directly and now it is called using the dialplan but it is not routed to the s extension.

I'm uploading a new CLI logs. Feel free to ask me any question regarding the CLI or my comment



By: Clod Patry (junky) 2006-04-24 07:16:11

what about your park-dial extension?
Did you used comebacktoorigin = no in features.conf ?

By: Clod Patry (junky) 2006-04-27 22:57:43

I need feedback here.

By: dimitripietro (dimitripietro) 2006-04-27 23:08:27

I will give you some update this weekend, I'm getting my hard phone tomorrow morning.

< what about your park-dial extension? >
What did you mean ?

< Did you used comebacktoorigin = no in features.conf >
Yes I did. With comebacktoorigin=yes, after the timeout, the device that parked him is automatically called. If the person is on the phone, the call is dropped.

With comebacktoorigin=no, instead of calling the device directly, after the timeout, the call is routed to the extension that originally parked him BUT using the dialplan.

Ex :
exten => 123,1,Dial(SIP/203)

A call is routed to this extension and the call is being parked by the called (203). After the timeout, instead of  contacting directly SIP/203 from the park-dial context, the call is retourned to the extension 123 priority 1

IF

exten => 123,1,Wait(2)
exten => 123,n,Dial(SIP/203)

Then after the timout, with the patch, the call will be routed to the extension 123 priority 2.

Sound clear ?

Dimitri



By: Serge Vecher (serge-v) 2006-05-08 18:43:22

dimitri: any progress with testing junky's patch?

By: dimitripietro (dimitripietro) 2006-05-08 21:29:38

Junky/vechers, Sorry for the long delay, I thought the bugs was deleted, I couldn't find it anymore. Anyway I have tested the patch and it's working but it depend on the way I do the transfert.

If I use the transfert function of the Polycom phone(attended), everything work fine. The call after the timeout is routed to the "s" extension.

 == Timeout for SIP/236-b18c parked on 701. Returning to internal,s,1
   -- Executing Answer("SIP/236-b18c", "") in new stack
   -- Executing Macro("SIP/236-b18c", "recordin") in new stack
   -- Executing Set("SIP/236-b18c", "CALLFILENAME=/var/spool/asterisk/monitor/entrant/236-s-") in new stack
   -- Executing Monitor("SIP/236-b18c", "wav|/var/spool/asterisk/monitor/entrant/236-s-|m") in new stack
   -- Executing Set("SIP/236-b18c", "DB(lastcaller/system)=236") in new stack
   -- Executing NoOp("SIP/236-b18c", "") in new stack
   -- Executing Dial("SIP/236-b18c", "SIP/202&SIP/236&IAX2/204|20|tTwW") in new stack
   -- Called 202
   -- Called 236


But if I use the Asterisk Unattended Transfert function after the timeout, The call is routed to the priority 1 of the extension that parked the call.

 == Timeout for SIP/236-e99a parked on 701. Returning to internal,202,1
   -- Executing Macro("SIP/236-e99a", "dial") in new stack
   -- Executing GotoIf("SIP/236-e99a", "0?boitevoc|1") in new stack
   -- Executing Set("SIP/236-e99a", "numForward202=null") in new stack
   -- Executing Set("SIP/236-e99a", "GROUP(202)=OUTBOUND_GROUP") in new stack
   -- Executing GotoIf("SIP/236-e99a", "0?106") in new stack
   -- Executing Set("SIP/236-e99a", "GROUP(236)=OUTBOUND_GROUP") in new stack
   -- Executing GotoIf("SIP/236-e99a", "1?7:9") in new stack
   -- Goto (macro-dial,s,7)
   -- Executing Dial("SIP/236-e99a", "SIP/202|20|tTwW") in new stack

If I use the Attended Asterisk Tranfert, the patch is working but it look strang e. It created an Local Channel, I don't know if it's the way you want it to be.

 == Timeout for Local/700@internal-140d,2 parked on 701. Returning to internal,      s,1
   -- Executing Answer("Local/700@internal-140d,2", "") in new stack
   -- Executing Macro("Local/700@internal-140d,2", "recordin") in new stack
   -- Executing Set("Local/700@internal-140d,2", "CALLFILENAME=/var/spool/aster      isk/monitor/entrant/202-s-") in new stack
   -- Executing Monitor("Local/700@internal-140d,2", "wav|/var/spool/asterisk/m      onitor/entrant/202-s-|m") in new stack
   -- Executing Set("Local/700@internal-140d,2", "DB(lastcaller/system)=202") i      n new stack
   -- Executing NoOp("Local/700@internal-140d,2", "") in new stack
   -- Executing Dial("Local/700@internal-140d,2", "SIP/202&SIP/236&IAX2/204|20|      tTwW") in new stack
   -- Called 202
   -- Called 236

Does it sound clear Junky ?

By: Clod Patry (junky) 2006-05-08 21:36:29

contact me offline at cpatry AT gmail.com , so we can fix these issues faster.



By: Steven BerkHolz (steveb) 2006-05-12 13:20:43

I would like to add a note to this request since it is very similar in nature and any code modifications would occur in the same areas of the file.

I propose that there be a variable "timeoutexten" that would be set in features.conf.
This variable would cause all parked calls that time out, go to only this one extension.
It could be defined as "timeoutexten => ext-local,5100" (our front desk)
This could also be used to send the calls to a ring group or an IVR.

Here is a CLI of the problem:
== Timeout for Zap/47-1 parked on 5401. Returning to park-dial,Zap/47,1
   -- Executing Dial("Zap/47-1", "Zap/47||t") in new stack
 == Everyone is busy/congested at this time (1:0/0/1)
   -- Hungup 'Zap/47-1'


The reason for this need is that many of our extensions are still on a legacy PBX connected via PRI, so the channel that is used by default (zap/12) will not call back the person that parked the call.



By: Clod Patry (junky) 2006-07-28 23:11:29

steveb: i agree with your idea here.
and if timeoutexten is not set? do the same behavior (return to the person that park the call, in 1.2 series, like russell said), what do you think?
this is more general concept of my comebacktoorigin=yes/no.


I discussed with dimitripietro, and apparently something is broken with my patch now, i will update it in 2 weeks with steveb concept, sinve ive to get out of the country.

During that time, if someone want to give an hand, feel free to assign that bug to urself.

By: Steven BerkHolz (steveb) 2006-07-31 08:18:32

timeoutexten and comebacktoorigin=yes/no can be complimentory.

If I understand correctly:
* comebacktoorigin=yes will send the call back to the parking channel. (will not work correctly on PRI, nor mISDN)
* comebacktoorigin=no will send the call to the timeoutexten
* timeoutexten would either be a receptionist exten or "s" or "t", etc.

Perhaps this may be simpler for the end user:
* timeoutexten=origin will send the call back to the parking channel. (will not work correctly on PRI, nor mISDN)
* timeoutexten=context/exten (actual values like int-ext/5100)to send to an fixed exten.
* timeoutexten=context/s to send to "s"
* timeoutexten=context/t to send to "t"
etc.

Only one parser. Look for word origin or use value as the context/exten.

By: zodiacal (zodiacal) 2006-07-31 19:12:41

can you guys tell me how to test this patch? i ran svn checkout http://svn.digium.com/svn/asterisk/trunk/res/ and got the res_features.c but it doesn't seem like it has the timeoutexten comebacktoorigin references. is this not the right file i need? i would really like this feature for parking. i want to append a string "PARKED" to my parked callerids so when it times out the people know its a parked call calling them back... any help would be great.

By: dimitripietro (dimitripietro) 2006-07-31 20:17:20

The patch is broken for the moment, Junky is out for two week then he will update the patch for the current svn.

By: alanj_29672 (alanj_29672) 2006-08-09 10:14:23

I would like to see there be an option to attempt to return the call to the person who parked it first, and then, after it fails to return the call, go to a timeout extension.

I guess technically I could do that with an extension, though, as long as I could access a variable that notes the extension that parked the call.

By: dimitripietro (dimitripietro) 2006-08-10 07:34:26

I agree with alanj_29672, a variable that contain the extension that parked the call and also a variable that contain the parking slot number the caller was in.

By: Clod Patry (junky) 2006-08-20 20:48:32

sorry for the delay.
ive made a new patch on 1.2.10, since the parked stuff is pretty broken in trunk atm.

The way it works,  you have a new variable in ur features.conf (called comebacktoorigin = yes/no , default is at yes).
If you set it to yes, after the parkedcalls timeout, its gonna call the person which parked it (old way), if that channel is unavaialbke, ur screwed.
If you set it to comebacktoorigin=no, you have to define a new context:

[parkedcallstimeout]
exten => s,1,DumpChan();
exten => s,n,Playback(tt-monkeys);



that will execute these CEPs, when parkedtimeout occurs.

Also, the inherited vars, are still available.
so you can still know who parked you, for any statistic reason you may need.

By: Serge Vecher (serge-v) 2006-08-21 10:17:50

junky: strange, I thought the Park() stuff worked pretty well in trunk. Maybe you should open a new bug for that, since I don't see any open for trunk.

By: ajmahler (diver) 2006-08-22 06:22:41

Hi Junky, thank you for working on this patch.

I patched 1.2.10 with the M6953_rev2.txt (patch -p0 <M6953_rev2...)
make clean;make;make install

tested the patch and did not see any change.

I was hoping to have the CallerIDNum change to the parking slot.

Currently the CallerID is *700.  I want it to change to the parking slot (ex: 701) so if it times out (which it frequently does here even with a timeout of 90 seconds) the receptionist knows which parking slot was used.  This way they can more professionally answer the returned call with "You were holding for Pat?  He didn't pick up, may I put you to his voicemail...."

Since the Receptionist probably parked the call and will most likely get the returned call I will not be able to use the parkedcallstimeout option.

I do not see where you are putting the variable containing the parking slot number.  I probably just not reading the notes clearly.  Please tell me how to change the CallerIDNum to the Parking Slot number.

Thanks!

By: Clod Patry (junky) 2006-08-22 10:32:44

the reason you did not hear any difference, it causes, it reacts the same way as before. Just add comebacktoorigin=no to ur conf.

By: ajmahler (diver) 2006-08-22 10:46:29

I probably didn't get it right.  I did set comebacktoorigin=no and created the [parkedcallstimeout]
exten => s,1,DumpChan();
exten => s,n,Playback(tt-monkeys);

It never went there.

What I really really really want is to be able to have the callerid change on the parked call to the actual parking slot number.  If I do *700 for the first time I want the call relabled "Parked Call <701>" for example.  This way the receptionist or anyone else for that matter knows which parked call is coming back to them.

I hope this clarifies what I need.  If I didn't configure my config's right, please let me know.

By: Clod Patry (junky) 2006-08-22 12:47:39

and the parked calls got timeouted? could you attach or CLI output (with debug enabled)?

By: ajmahler (diver) 2006-08-22 14:02:35

I will test tonight or early morning and get you the debug.

By: dimitripietro (dimitripietro) 2006-08-22 21:40:46

Junky, I'm presently using the pathc in one production box and everything is fine. Some warning in the CLI, but it's working. I'm not sure if the error are due to some of my modification or from the patch itself. I will post my CLI.

I don't know if you can change the CAllerid to the number of the parking slot the user was in. I'm not sure there is a var containing this information.



By: ajmahler (diver) 2006-08-23 05:52:21

dimitripietro, why wouldn't you want the call to have the slot for the caller id number?  What better way to track the call?  If all the parked calls are *700 how do you tell them apart?

I absolutely need to be able to label parked calls by where they were parked.  Perhaps I need to post this somewhere else and leave this bug report.  I just thought it would be very simple thing to do or it had been done based on reading of the notes.

My client is holding back money until I can get this done.

Anybody got an idea on how to do this?

By: Clod Patry (junky) 2006-08-23 07:39:01

what about if we set a chanvar only on timeout with the parkingslot?
you will have to overwrite, in parkedcallstimeout context your cid_num with that value?

By: ajmahler (diver) 2006-08-23 10:09:42

I'd be happy to give that a try!

By: ajmahler (diver) 2006-08-24 05:44:16

Junky,

Why can't we change the extension number from *700 to the actually parking spot?  Wouldn't that be simpler in general?


[parkedcalls]
exten => _*7XX,1,SetCallerID(Parked Call <b>${EXTEN}</b>)
exten => _*7XX,n,ParkAndAnnounce(pbx-transfer:PARKED|9|SIP/${DIALEDPEERNUMBER}|motors|${DIALEDPEERNUMBER}|1)

By: ajmahler (diver) 2006-08-24 05:59:26

Hey Junky,

I tested again with the patch and the config changes noted in this document.  I saw zero difference in the way the call came out of call parking.  I have metermaid patch also, does that make a difference?

Thanks!

By: Clod Patry (junky) 2006-08-24 07:05:57

its normal, the patch with setting the parkingslot on timeout isnt coded yet.
will try to do that in the week-end.

By: ajmahler (diver) 2006-08-24 08:26:28

Junky,  Thanks for giving up part of your weekend to help me.  

I didn't actually mean that you hadn't programmed the chan var yet.  I meant that I patched my source, recompiled and changed my configs as I mentioned.

The [parkedtimeout] context was never reached.  Could it be that because I have call waiting enabled?

By: Clod Patry (junky) 2006-08-24 20:34:28

rev3 set the chanvar PARKINGSLOT in the channel that was parked, only if the timeout occurs and the callbacktoorigin=no. all other case, that var is not set.

so, you can do whatever you want with it, like spoofing the cid_num with that chanvar.


[parkedcallstimeout]
exten => s,1,NoOp(user was parked on parkingslot #${PARKINGSLOT});
exten => s,n,Playback(tt-monkeys);



the reason, that context is proably cause you dont have callbacktoorigin=no in ur features.conf. call waiting has nothing to do here, since you dont recall the person which parked the call...

Also, you can apply the patch to newest 1.2.11



By: ajmahler (diver) 2006-08-28 06:44:04

Junky,  Thanks again for working on this.  The extension range but the variable didn't produce a value.  I am sure I did something wrong.  Please check out my config:

[parkedcalls]
exten => _*7XX,1,SetCallerID(Parked Call <70X>)
exten => _*7XX,n,ParkAndAnnounce(pbx-transfer:PARKED|9|SIP/${DIALEDPEERNUMBER}|parkedcallstimeout|s|1)

;features.conf
[general]
parkpos => 701-729
context => parkedcalls
courtesytone = beep
xfersound = beep
xferfailsound = beeperr
findslot => first
featuredigittimeout = 500
transferdigittimeout => 3
callbacktoorigin=no

[parkedcallstimeout]
exten => s,1,NoOp(user was parked on parkingslot #${PARKINGSLOT});
exten => s,n,Playback(tt-monkeys);

By: Clod Patry (junky) 2006-08-28 11:40:53

try removing ur context parkedcalls, let the one on the res_features deals it.

Also, post ur CLI output, with debug enabled.

By: ajmahler (diver) 2006-08-29 10:35:55

Hey Junky,

I ran the cli with debug on the phone I was testing with.  I did not see a value come back on the channel variable.  I changed the config per your recommendations.  What do you think I am doing wrong?

Additionally, changing the config broke the meter-maid-1.2.7 patch for the blf appearance.  The first slot light did not come on at all for the GXP-2000 phone and the other 5 (702-706) stayed red at all times.

Thanks for working on this!

A. J.

By: Clod Patry (junky) 2006-08-29 10:47:15

that patch works with fresh 1.2 branch, did not tested with metermaid, nor blf.


If you could try without metermaid, and if everything works fine, i will update oej's patch for metermaid to get this stuff working.

By: ajmahler (diver) 2006-08-29 10:49:59

Thanks Junky,

I will test tonight.  You are awesome!

aj

By: Serge Vecher (serge-v) 2006-08-29 11:07:58

ok, how about some trunk patches too ;)

By: k-egg (k-egg) 2006-09-04 02:52:03

as ASTERISK-7240 is closed for now, i want to keep in mind, that parkedcalls still fail to return to the extension that parked it after a timeout using PRI or mISDN

By: dimitripietro (dimitripietro) 2006-09-04 16:26:37

Junky,

I'm will test the patch with 1.2.11 + metermaid. W will give you some news in two days.

By: Clod Patry (junky) 2006-09-04 18:20:16

k-egg: follow ur bug at ASTERISK-7240.

By: Richard Miller (ulogic) 2006-09-04 20:55:52

trunk version r41865, res_features.c version 41696
First let me say that the built-in call parking works correctly.  However, when invoking Park() and ParkedCall() from a dialplan, there are multiple problems, both in the trunk version and in the current release 1.2.11.

Problem 1. (major)
Start by entering # to invoke a blind transfer.  Calling Park() in a dialplan plays the parking space number to wrong party.  If the parking time elapses, rather than calling back the party who initiated the transfer, it attempts to reconnect the party, who is on hold, back to himself.  Transferring to an invalid extension makes the transferee follow the invalid extension path in the dialplan rather then the transferer.

The built-in call parking calls (with 2 different channel objects)
ast_park_call(transferee, transferer, 0, NULL)
but the dial plen application uses a single channel object
ast_park_call(chan, chan, 0, NULL)

It looks like we need to compare the channel object against $(BLINDTRANSFER} and ${DIALEDPEERNAME) to determine the partners in the transfer and who initiated it.  Perhaps I can even take a crack at fixing it, but I have to dig through the code some more to understand how things tie together.  Also, not coming from the Linux world, I need to learn a little more about CVS/subversion before posting a patch.

Problem 2. (major)
In the trunk version, you can pick a specific parking place with the Park() application.  I am using phone extensions 100-199 and parking places 4001-4199.  I use extension 40 for the built-in parking feature starting at 4001, and extension 41 to park in a place associated with the extension.  The call will park in the correct location as it can be displayed with "show parkedcalls".  However, you can't pick up the call with ParkedCall().

exten => 41,1,Macro(getmyext)
exten => 41,n,Set(PARKINGEXTEN=4${myext})
exten => 41,n,Park()
exten => _4XXX,1,ParkedCall(${EXTEN})
[macro-getmyext]
exten => s,1,Set(mychan=${CHANNEL})     ; Call originator
exten => s,n,ExecIf($[${LEN(${BLINDTRANSFER})}],Set,mychan=${BLINDTRANSFER})
                                       ; Peer invoked the transfer
exten => s,n,Set(myext=${CUT(mychan,-,1)})
                                       ; Extract SIP/EXT
exten => s,n,Set(myext=${CUT(myext,/,2)})
                                       ; Extract EXT

Problem 3. (minor)
After pressing # to initiate a blind transfer, the log shows
-- Started music on hold, class 'default', on ${CHANNEL}
-- Playing 'pbx-transfer' (language 'en')
WARNING[1196]: file.c:553 ast_openstream_full: File /var/lib/asterisk/moh/ does not exist in any format
WARNING[1196]: res_musiconhold.c:246 ast_moh_files_next: Unable to open file /var/lib/asterisk/moh/': No such file or directory
-- Stopped music on hold on ${CHANNEL}

Problem 4. (annoyance)
With varied lengths of extensions in the dialplan, it would be nice to have an initial or total timeout as well as an interdigit timeout for parforming a transfer.  With a 2 second timeout, it's easy to not react in time and end up not dialing a complete extension.  With a 5 or 6 second timeout, you have to wait a relatively long time after the last digit, and a person might hang up too early, not realizing that the transfer has not yet completed.

By: dimitripietro (dimitripietro) 2006-09-08 07:46:34

Junky,

The patch is working well, could you create the same patch for the trunk ?

By: Anthony LaMantia (alamantia) 2006-09-19 17:55:46

dimitripietro  ping

By: dimitripietro (dimitripietro) 2006-09-19 23:27:49

pong

By: Clod Patry (junky) 2006-09-23 21:23:24

dimitripietro contacted me and let me know he's using my latest patch in production. apparently this is working really well.

Now the question, do we want that exact behavior (see M6953_rev3.txt ) after calls are parked?
Russell, since you expressed your feeling at the beginning of this bug, what are your comments?

By: Ronald Chan (loloski) 2006-09-24 11:30:24

Guys,

for those people want to test Junky's patch  M6953_rev3.txt but this time in SVN-1.4-beta2 branch r43564 please test this patch.



Best regards,

Ronald

By: Anthony LaMantia (alamantia) 2006-09-26 15:49:29

can you supply us with a patch that applies clean aginst the current version of asterisk trunk?

By: Ronald Chan (loloski) 2006-09-27 07:01:50

alamantia,

r43658 | tilghman | 2006-09-27 00:28:01 +0800 (Wed, 27 Sep 2006) | 2 lines

the patch still applies cleanly to this last commit

svn co http://svn.digium.com/svn/asterisk/trunk asterisk ? is this the trunk you are referring to?

DISCLAIMER is not _SENT_ sorry i don't have any access to fax machine able to make international dial hope you understand. you could apply the source freely as you see it fit.


p.s.

Sorry for my english, since i'm not a native english speaker

Best regards,

Ronald

By: Clod Patry (junky) 2006-09-27 07:06:09

you dont need a disclaimer, since i wrote the code.
You just ported it to trunk.

By: Ronald Chan (loloski) 2006-09-27 07:10:39

Junky,

Oh i see, well that would be great :) your patch is running on my production server, it's really nice thou.... thanks junky


Best regards,

Ronald

By: Matt O'Gorman (mogorman) 2006-10-31 18:08:11.000-0600

Committed revision 46732. into trunk