Asterisk
  1. Asterisk
  2. ASTERISK-746

[patch] preliminary upgrade to app_dial.c for Privacy

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/General
    • Labels:
      None
    • Mantis ID:
      752
    • Regression:
      No

      Description

      Refer to message from Steve Murphy to asterisk-dev mailing
      list on 4 Jan 2004; (Digest ASTERISK-424). Basically, this
      is a extremely prelim attempt to flesh out the Privacy
      option for the Dial command. Before investing more time
      in coding, I need some reassurance that the proper approach
      is being taken. PLEASE review the attached changes (diff -u format), and give me some feedback, PLEASE.

        Activity

        Hide
        Steve Murphy added a comment -

        I have uploaded privacy-omnibus2.diffu, which supercedes the older privacy-omnibus file.

        I have modified the 5 strncpy calls to ast_copy_string calls. The third arg, if it had an x-1 value, has been modified to just x.

        and the // comments are now /* comments */.

        I compiled and ran a test before reforming the patch. All is still well.

        Show
        Steve Murphy added a comment - I have uploaded privacy-omnibus2.diffu, which supercedes the older privacy-omnibus file. I have modified the 5 strncpy calls to ast_copy_string calls. The third arg, if it had an x-1 value, has been modified to just x. and the // comments are now /* comments */. I compiled and ran a test before reforming the patch. All is still well.
        Hide
        Steve Murphy added a comment -

        Is there anything remaining on this issue for me to do? It seems to be pretty quiet, after a rush of activity... it's a year and half now... ?
        Is everybody busy, testing this out?

        Show
        Steve Murphy added a comment - Is there anything remaining on this issue for me to do? It seems to be pretty quiet, after a rush of activity... it's a year and half now... ? Is everybody busy, testing this out?
        Hide
        Kevin P. Fleming (Inactive) added a comment -

        Committed to CVS HEAD, thanks!

        Show
        Kevin P. Fleming (Inactive) added a comment - Committed to CVS HEAD, thanks!
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 3801

        U trunk/app.c
        U trunk/apps/app_voicemail.c
        U trunk/include/asterisk/app.h

        ------------------------------------------------------------------------
        r3801 | markster | 2008-01-15 15:07:44 -0600 (Tue, 15 Jan 2008) | 2 lines

        Move routines from voicemail to app for general use (part of bug ASTERISK-746)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=3801

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 3801 U trunk/app.c U trunk/apps/app_voicemail.c U trunk/include/asterisk/app.h ------------------------------------------------------------------------ r3801 | markster | 2008-01-15 15:07:44 -0600 (Tue, 15 Jan 2008) | 2 lines Move routines from voicemail to app for general use (part of bug ASTERISK-746 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3801
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 6102

        U trunk/Makefile
        U trunk/apps/app_dial.c
        U trunk/configs/extensions.conf.sample
        A trunk/doc/README.privacy
        A trunk/sounds/priv-callee-options.gsm
        A trunk/sounds/priv-callpending.gsm
        A trunk/sounds/priv-introsaved.gsm
        A trunk/sounds/priv-recordintro.gsm
        A trunk/sounds/screen-callee-options.gsm
        U trunk/sounds.txt

        ------------------------------------------------------------------------
        r6102 | kpfleming | 2008-01-15 15:41:00 -0600 (Tue, 15 Jan 2008) | 2 lines

        add privacy/screening functionality to app_dial (bug ASTERISK-746)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=6102

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 6102 U trunk/Makefile U trunk/apps/app_dial.c U trunk/configs/extensions.conf.sample A trunk/doc/README.privacy A trunk/sounds/priv-callee-options.gsm A trunk/sounds/priv-callpending.gsm A trunk/sounds/priv-introsaved.gsm A trunk/sounds/priv-recordintro.gsm A trunk/sounds/screen-callee-options.gsm U trunk/sounds.txt ------------------------------------------------------------------------ r6102 | kpfleming | 2008-01-15 15:41:00 -0600 (Tue, 15 Jan 2008) | 2 lines add privacy/screening functionality to app_dial (bug ASTERISK-746 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6102

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development