Asterisk
  1. Asterisk
  2. ASTERISK-7871

[patch] The record# parameter in ENUMLOOKUP is ignored

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Functions/NewFeature
    • Labels:
      None
    • SVN Revision Number:
      50028
    • Mantis ID:
      8089
    • Regression:
      No

      Description

      In function_enum, the args.record parameter is never evaluated.

      That's also a bug in ast_get_enum, which does not offer a seperate parameter for this.

                • ADDITIONAL INFORMATION ******

      I started to fix this and got a bit carried away: I've incorporated the ideas of http://bugs.digium.com/view.php?id=5526 and http://bugs.digium.com/view.php?id=5666 into this patch as well. Cleaned up the options parameter, removed a lot of cruft from enum.c (e.g. the search list of domains which was dead code since the demise of the ENUM application), updated the documentation, cleaned up the ISN/ITAD stuff and integrated it into a consistent options scheme. I've also sanitized the code for TXTCIDNAME.

      So, yes, this patch is a bit heavy for 1.4. But we really need to fix the issues I list above, those are real bugs. One can certainly extract the points which just fix the bug. You'de loose out on a lot of cleanup work, though.

      1. 1.4-enum-changes.diff
        32 kB
        snuffy
      2. 20080326__bug8089.diff.txt
        30 kB
        Tilghman Lesher
      3. 20080505-bbryant-dialplan_enum_tests.txt
        1 kB
      4. 20080506_bug8089.diff
        32 kB
        snuffy
      5. 20080507_bug8089.diff
        34 kB
        snuffy
      6. 20080507-1339_8089.diff
        36 kB
        snuffy
      7. 20080508_bug8089.diff
        36 kB
        snuffy
      8. 20080508_bug8089-1.diff
        36 kB
        snuffy
      9. asterisk-1.4.0-beta2-enum-simple.diff
        5 kB
      10. asterisk-1.4.0-beta2-ienum.diff
        40 kB
      11. bug8089_bbryant_cclen-patch_20080506.diff
        34 kB
        Brett Bryant
      12. enum-doc-update.diff
        5 kB
        snuffy
      13. enum-extensions-test.txt
        5 kB
      14. enum-trunk-update.dff
        31 kB
        snuffy
      15. exten_enum_test.conf
        6 kB
      16. svn-ienum-20070111.diff
        39 kB

        Activity

        Hide
        snuffy added a comment -

        Sorry about that guys..
        It should patch fine now.

        Show
        snuffy added a comment - Sorry about that guys.. It should patch fine now.
        Hide
        John Todd added a comment -

        OK, this latest patch passes all my tests. Can some other people test it, please?

        Show
        John Todd added a comment - OK, this latest patch passes all my tests. Can some other people test it, please?
        Hide
        Brett Bryant added a comment -

        This has also passed the tests I had been running. I'll do some more testing with the new features and such some time today.

        Thanks Snuffy, for doing all the work on this patch.

        Show
        Brett Bryant added a comment - This has also passed the tests I had been running. I'll do some more testing with the new features and such some time today. Thanks Snuffy, for doing all the work on this patch.
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115584

        U trunk/funcs/func_enum.c
        U trunk/include/asterisk/enum.h
        U trunk/main/enum.c

        ------------------------------------------------------------------------
        r115584 | bbryant | 2008-05-09 14:48:54 -0500 (Fri, 09 May 2008) | 15 lines

        The following patch adds new options and alters the default behavior of the ENUM* functions. The TXCIDNAME lookup function has also gotten a
        new paramater. The new options for ENUM* functions include 'u', 's', 'i', and 'd' which return the full uri, trigger isn specific rewriting, look
        for branches into an infrastructure enum tree, or do a direct dns lookup of a number respectively. The new paramater for TXCIDNAME adds a
        zone-suffix argument for looking up caller id's in DNS that aren't e164.arpa.

        This patch is based on the original code from otmar, modified by snuffy, and tested by jtodd, me, and others.

        (closes issue ASTERISK-7871)
        Reported by: otmar
        Patches:
        20080508_bug8089-1.diff

        • original code by otmar (license 480),
        • revised by snuffy (license 35)
          Tested by: oej, otmar, jtodd, Corydon76, snuffy, alexnikolov, bbryant

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115584

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115584 U trunk/funcs/func_enum.c U trunk/include/asterisk/enum.h U trunk/main/enum.c ------------------------------------------------------------------------ r115584 | bbryant | 2008-05-09 14:48:54 -0500 (Fri, 09 May 2008) | 15 lines The following patch adds new options and alters the default behavior of the ENUM* functions. The TXCIDNAME lookup function has also gotten a new paramater. The new options for ENUM* functions include 'u', 's', 'i', and 'd' which return the full uri, trigger isn specific rewriting, look for branches into an infrastructure enum tree, or do a direct dns lookup of a number respectively. The new paramater for TXCIDNAME adds a zone-suffix argument for looking up caller id's in DNS that aren't e164.arpa. This patch is based on the original code from otmar, modified by snuffy, and tested by jtodd, me, and others. (closes issue ASTERISK-7871 ) Reported by: otmar Patches: 20080508_bug8089-1.diff original code by otmar (license 480), revised by snuffy (license 35) Tested by: oej, otmar, jtodd, Corydon76, snuffy, alexnikolov, bbryant ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115584
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115585

        _U branches/1.6.0/

        ------------------------------------------------------------------------
        r115585 | bbryant | 2008-05-09 14:49:51 -0500 (Fri, 09 May 2008) | 22 lines

        Blocked revisions 115584 via svnmerge

        ........
        r115584 | bbryant | 2008-05-09 14:54:45 -0500 (Fri, 09 May 2008) | 15 lines

        The following patch adds new options and alters the default behavior of the ENUM* functions. The TXCIDNAME lookup function has also gotten a
        new paramater. The new options for ENUM* functions include 'u', 's', 'i', and 'd' which return the full uri, trigger isn specific rewriting, look
        for branches into an infrastructure enum tree, or do a direct dns lookup of a number respectively. The new paramater for TXCIDNAME adds a
        zone-suffix argument for looking up caller id's in DNS that aren't e164.arpa.

        This patch is based on the original code from otmar, modified by snuffy, and tested by jtodd, me, and others.

        (closes issue ASTERISK-7871)
        Reported by: otmar
        Patches:
        20080508_bug8089-1.diff

        • original code by otmar (license 480),
        • revised by snuffy (license 35)
          Tested by: oej, otmar, jtodd, Corydon76, snuffy, alexnikolov, bbryant

        ........

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115585

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115585 _U branches/1.6.0/ ------------------------------------------------------------------------ r115585 | bbryant | 2008-05-09 14:49:51 -0500 (Fri, 09 May 2008) | 22 lines Blocked revisions 115584 via svnmerge ........ r115584 | bbryant | 2008-05-09 14:54:45 -0500 (Fri, 09 May 2008) | 15 lines The following patch adds new options and alters the default behavior of the ENUM* functions. The TXCIDNAME lookup function has also gotten a new paramater. The new options for ENUM* functions include 'u', 's', 'i', and 'd' which return the full uri, trigger isn specific rewriting, look for branches into an infrastructure enum tree, or do a direct dns lookup of a number respectively. The new paramater for TXCIDNAME adds a zone-suffix argument for looking up caller id's in DNS that aren't e164.arpa. This patch is based on the original code from otmar, modified by snuffy, and tested by jtodd, me, and others. (closes issue ASTERISK-7871 ) Reported by: otmar Patches: 20080508_bug8089-1.diff original code by otmar (license 480), revised by snuffy (license 35) Tested by: oej, otmar, jtodd, Corydon76, snuffy, alexnikolov, bbryant ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115585

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development