Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/General
    • Labels:
      None
    • SVN Revision Number:
      46037
    • Mantis ID:
      8160
    • Regression:
      No

      Description

      Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const_correctness" to your sources at more places?
      I suggest to add the key word "const" to the type specifiers of parameters like the following.

      • cmd, parse (function "filter")
      • tmpl (function "chan_misdn_log")
      • state, exten, callerid, format, port, c (function "misdn_new")
      • name (function "create_name")
      • exten (function "ast_get_extension_...")
      1. app_db.c.rej
        2 kB
      2. bug 8160 const4 patch results.txt
        8 kB
      3. const3.patch
        10 kB
      4. const4.patch
        100 kB

        Activity

        Hide
        Tilghman Lesher added a comment -

        elfring: please use the command line tools to generate your patch. You will not be told again. We don't care what your GUI shows; your patch has conflicts.

        Show
        Tilghman Lesher added a comment - elfring: please use the command line tools to generate your patch. You will not be told again. We don't care what your GUI shows; your patch has conflicts.
        Hide
        Russell Bryant added a comment -

        I would be happy to apply this patch once it is updated to apply cleanly to the trunk and compile ...

        Show
        Russell Bryant added a comment - I would be happy to apply this patch once it is updated to apply cleanly to the trunk and compile ...
        Hide
        Markus Elfring added a comment -

        Thanks for your patience.

        I would like to know the real reasons for the rejections by the patch program...
        http://cygwin.com/ml/cygwin/2007-01/msg00290.html

        Show
        Markus Elfring added a comment - Thanks for your patience. I would like to know the real reasons for the rejections by the patch program... http://cygwin.com/ml/cygwin/2007-01/msg00290.html
        Hide
        Serge Vecher added a comment -

        I would like to know whether you are going to address the suggestions by the development team and provide an updated trunk patch.

        Show
        Serge Vecher added a comment - I would like to know whether you are going to address the suggestions by the development team and provide an updated trunk patch.
        Hide
        Russell Bryant added a comment -

        I'm closing this out. Feel free to re-open if you are able to generate a patch that can apply to svn trunk.

        Show
        Russell Bryant added a comment - I'm closing this out. Feel free to re-open if you are able to generate a patch that can apply to svn trunk.

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development