[Home]

Summary:ASTERISK-08214: [patch] Allow whisper functionality in Meetme
Reporter:Tony Zhao (tony zhao)Labels:
Date Opened:2006-11-29 14:59:13.000-0600Date Closed:2011-06-07 14:03:25
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.c.svndiff
( 1) app_meetme.c.svndiff2
( 2) app_meetme.svndiff
Description:In Meetme, certain users can private whisper othe users through the 'whisper' functionality similar to ChanSpy which does not work for my purposes.  

See issue 0008437

I am trying to synthesis a speech file from text in a web interface using freetts agi script and play that to a specific user given conference number, user number, and filename.

For my purposes I made a small patch that works for my specific purpose in Meetme.  This is because ChanSpy does not work as expected.  However I think ChanSpy would be better since it would be more general.

Let me know if you plan to fix ChanSpy or I should submit a patch with my 'fix'
Comments:By: Anthony LaMantia (alamantia) 2006-11-29 15:07:47.000-0600

i dont know of anyone working on such a thing, if you want to submit code to us here you need to file a dislciamer with digium, aslo.. you may want to consider posting your ideas/code to the asterisk-dev mailing list rather then to the bug tracker when it involves issues such as this.

By: Anthony LaMantia (alamantia) 2006-11-30 17:13:52.000-0600

tony,
are you planning to submit a disclaimer and your patch?

By: Tony Zhao (tony zhao) 2006-11-30 17:25:46.000-0600

I will submit a patch shortly, you already have my disclaimer I think.

By: Anthony LaMantia (alamantia) 2006-11-30 18:14:48.000-0600

cool, sounds good.



By: Anthony LaMantia (alamantia) 2006-12-04 11:44:13.000-0600

i've sent in a request for the the status of your disclaimer with digium.
once we have a confirmation you can upload your patch to mantis.

By: Tony Zhao (tony zhao) 2006-12-11 14:00:21.000-0600

Here is the patch.  Against SVN trunk 48388.

By: Serge Vecher (serge-v) 2006-12-11 14:08:04.000-0600

thanks Tony:

a. Could you please fix up the formatting in the patch?
  1) Use tabs instead of spaces for indentation
  2) Single line if else constructs do not need curly brackets
b. Make sure there are no unrelated changes, like the first chunk of the patch.

Thanks!

By: Tony Zhao (tony zhao) 2006-12-11 14:08:23.000-0600

I also included a 'z' flag.

'z' -- all dtmf key events will be sent to the manager\n";

This allows the flexbility for users hook their own manager commands to the meetme system by getting what key is pressed and then issuing their own manager command.  Currently everything is hardcoded which is not customizable.

By: Tony Zhao (tony zhao) 2006-12-11 14:31:43.000-0600

Reuploaded

By: Anthony LaMantia (alamantia) 2006-12-12 17:47:34.000-0600

Tony,

digium has no disclaimer on file for your mantis username, did you file it under the name of the compnay you work for?

By: Tony Zhao (tony zhao) 2006-12-12 17:58:45.000-0600

Possibly.

I work for Sun Microsystems.
My full name is Tony Yu Zhao.

By: Anthony LaMantia (alamantia) 2006-12-13 12:51:36.000-0600

ah, Sun Microsystems has a blanket disclaimer on file with us, are you releaseing the code under that disclaimer on behalf of sun? or do you wish to file one for yourself.

By: Tony Zhao (tony zhao) 2006-12-13 13:40:40.000-0600

I will refax my disclaimer today.

By: Clod Patry (junky) 2007-03-15 22:34:12

What's the status of this disclaimer now?

By: George Drayer (gdrayer) 2007-04-19 13:20:08

Has there been any movement on this?



By: Eliel Sardanons (eliel) 2007-05-24 17:27:12

I make this patch for current SVN trunk revision 66066 (with minor changes).

By: Joshua C. Colp (jcolp) 2007-05-25 08:48:21

The underlying issue preventing Chanspy whisper from operating in this fashion has now been solved in 1.4 as of revision 66074 and trunk as of revision 66109.

By: Joshua C. Colp (jcolp) 2007-06-27 18:36:21

I'm suspending this for now since the underlying issue preventing the Chanspy whisper method has been fixed. If anyone would like to fix up this patch though, feel free to reopen. Note though there's actually two features in there...