Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/Configuration
    • Labels:
      None
    • Mantis ID:
      9676
    • Regression:
      No

      Description

      No res_pgsql.conf.sample or sql script. I've attached ones the same as listed at:

      http://www.asteriskguru.com/tutorials/realtime_pgsql.html

      Why was res_config_pgsql.c included without these or a README?

      Lastly, I heard that res_config_pgsql.c was going to be dropped in favour of ODBC connections, can you confirm this?

      Thanks.

                • ADDITIONAL INFORMATION ******

      extconfig.conf example:

      iaxusers => pgsql,asterisk,sip_conf
      iaxpeers => pgsql,asterisk,sip_conf
      sipusers => pgsql,asterisk,sip_conf
      sippeers => pgsql,asterisk,sip_conf
      voicemail => pgsql,asterisk,voicemail_users
      extensions => pgsql,asterisk,extensions_conf
      queues => pgsql,asterisk,queue_table
      queue_members => pgsql,asterisk,queue_member_table

      res_pgsql.conf example:

      ;
      ; Sample configuration for res_config_pgsql.c
      ;
      ; The value of dbhost may be either a hostname or an IP address.
      ; If dbhost is commented out or the string "localhost", a connection
      ; to the local host is assumed and dbsock is used instead of TCP/IP
      ; to connect to the server.
      ;
      [general]
      dbhost=127.0.0.1
      dbport=5432
      dbname=asterisk
      dbuser=asterisk
      dbpass=suretec

        Activity

        Hide
        Russell Bryant added a comment -

        This has been merged into 1.4 and trunk in revisions 63329 aned 63330. Thanks!

        Also, there are no plans to deprecate the use of res_config_pgsql, and I don't anticipate that happening.

        Show
        Russell Bryant added a comment - This has been merged into 1.4 and trunk in revisions 63329 aned 63330. Thanks! Also, there are no plans to deprecate the use of res_config_pgsql, and I don't anticipate that happening.
        Hide
        Gavin Henry added a comment -

        Sorry to re-open, but realtime_pgsql.sql should go into the contrib/scripts section like other .sql files.

        Gavin.

        Show
        Gavin Henry added a comment - Sorry to re-open, but realtime_pgsql.sql should go into the contrib/scripts section like other .sql files. Gavin.
        Hide
        Russell Bryant added a comment -

        Done! Thanks!

        Show
        Russell Bryant added a comment - Done! Thanks!
        Hide
        Gavin Henry added a comment -

        I have also been testing this at the same time as res_ldap, and noticed the .sql file has the cdr table in it, which is already covered by the cdr psql script in contrib.

        Should it be removed? Can an author statement also be added to the res file?

        Show
        Gavin Henry added a comment - I have also been testing this at the same time as res_ldap, and noticed the .sql file has the cdr table in it, which is already covered by the cdr psql script in contrib. Should it be removed? Can an author statement also be added to the res file?
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115557

        D branches/1.4/contrib/scripts/postgres_cdr.sql

        ------------------------------------------------------------------------
        r115557 | russell | 2008-05-08 10:32:12 -0500 (Thu, 08 May 2008) | 3 lines

        remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well
        (closes issue ASTERISK-9393)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115557

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115557 D branches/1.4/contrib/scripts/postgres_cdr.sql ------------------------------------------------------------------------ r115557 | russell | 2008-05-08 10:32:12 -0500 (Thu, 08 May 2008) | 3 lines remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well (closes issue ASTERISK-9393 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115557
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115558

        _U trunk/
        D trunk/contrib/scripts/postgres_cdr.sql

        ------------------------------------------------------------------------
        r115558 | russell | 2008-05-08 10:32:50 -0500 (Thu, 08 May 2008) | 11 lines

        Merged revisions 115557 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines

        remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well
        (closes issue ASTERISK-9393)

        ........

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115558

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115558 _U trunk/ D trunk/contrib/scripts/postgres_cdr.sql ------------------------------------------------------------------------ r115558 | russell | 2008-05-08 10:32:50 -0500 (Thu, 08 May 2008) | 11 lines Merged revisions 115557 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well (closes issue ASTERISK-9393 ) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115558
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115559

        _U branches/1.6.0/
        D branches/1.6.0/contrib/scripts/postgres_cdr.sql

        ------------------------------------------------------------------------
        r115559 | russell | 2008-05-08 10:33:10 -0500 (Thu, 08 May 2008) | 19 lines

        Merged revisions 115558 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r115558 | russell | 2008-05-08 10:38:27 -0500 (Thu, 08 May 2008) | 11 lines

        Merged revisions 115557 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines

        remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well
        (closes issue ASTERISK-9393)

        ........

        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115559

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115559 _U branches/1.6.0/ D branches/1.6.0/contrib/scripts/postgres_cdr.sql ------------------------------------------------------------------------ r115559 | russell | 2008-05-08 10:33:10 -0500 (Thu, 08 May 2008) | 19 lines Merged revisions 115558 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r115558 | russell | 2008-05-08 10:38:27 -0500 (Thu, 08 May 2008) | 11 lines Merged revisions 115557 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well (closes issue ASTERISK-9393 ) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115559
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 115574

        _U team/seanbright/res-jabber-astobj2/
        U team/seanbright/res-jabber-astobj2/channels/chan_h323.c
        U team/seanbright/res-jabber-astobj2/channels/chan_iax2.c
        U team/seanbright/res-jabber-astobj2/channels/chan_sip.c
        U team/seanbright/res-jabber-astobj2/channels/chan_zap.c
        U team/seanbright/res-jabber-astobj2/contrib/init.d/rc.debian.asterisk
        U team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldap-schema
        U team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldif
        D team/seanbright/res-jabber-astobj2/contrib/scripts/postgres_cdr.sql
        _U team/seanbright/res-jabber-astobj2/include/asterisk/dlinkedlists.h
        U team/seanbright/res-jabber-astobj2/main/pbx.c
        U team/seanbright/res-jabber-astobj2/main/sched.c
        U team/seanbright/res-jabber-astobj2/res/res_config_ldap.c
        U team/seanbright/res-jabber-astobj2/res/res_odbc.c
        U team/seanbright/res-jabber-astobj2/sounds/Makefile

        ------------------------------------------------------------------------
        r115574 | seanbright | 2008-05-08 19:10:45 -0500 (Thu, 08 May 2008) | 243 lines

        Merged revisions 115507,115509,115513,115515,115518-115519,115521,115523,115525,115535,115537,115546,115548,115552,115555,115558,115562,115566,115569 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r115507 | file | 2008-05-07 09:41:25 -0400 (Wed, 07 May 2008) | 4 lines

        Remove redundant header getting.
        (closes issue ASTERISK-11984)
        Reported by: hooi

        ................
        r115509 | tilghman | 2008-05-07 09:49:15 -0400 (Wed, 07 May 2008) | 6 lines

        Update typos in description fields
        (closes issue ASTERISK-11985)
        Reported by: suretec
        Patches:
        asterisk_schema_changes.patch uploaded by suretec (license 70)

        ................
        r115513 | russell | 2008-05-07 13:28:19 -0400 (Wed, 07 May 2008) | 19 lines

        Merged revisions 115512 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ................
        r115512 | russell | 2008-05-07 11:24:09 -0500 (Wed, 07 May 2008) | 11 lines

        Merged revisions 115511 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.2

        ........
        r115511 | russell | 2008-05-07 11:22:49 -0500 (Wed, 07 May 2008) | 3 lines

        Remove remnants of dlinkedlists. I didn't actually use them in the final version
        of my IAX2 improvements.

        ........

        ................

        ................
        r115515 | russell | 2008-05-07 13:38:36 -0400 (Wed, 07 May 2008) | 2 lines

        re-add dlinkedlists.h to trunk, oops!

        ................
        r115518 | russell | 2008-05-07 14:17:43 -0400 (Wed, 07 May 2008) | 12 lines

        Blocked revisions 115517 via svnmerge

        ........
        r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines

        Track peer references when stored in the sip_pvt struct as the peer related to
        a qualify ping or a subscription. This fixes some realtime related crashes.
        (closes issue ASTERISK-11976)
        (closes issue ASTERISK-11945)

        ........

        ................
        r115519 | russell | 2008-05-07 14:24:51 -0400 (Wed, 07 May 2008) | 2 lines

        Let chan_h323 build in dev mode

        ................
        r115521 | russell | 2008-05-07 14:30:12 -0400 (Wed, 07 May 2008) | 7 lines

        Use the default that the log output claims will be used for the basedn

        (closes issue ASTERISK-11986)
        Reported by: suretec
        Patches:
        12599.patch uploaded by juggie (license 24)

        ................
        r115523 | russell | 2008-05-07 14:33:50 -0400 (Wed, 07 May 2008) | 6 lines

        Only save a password if a username exists.

        (closes issue ASTERISK-11987)
        Reported By: suretec
        Patch by me

        ................
        r115525 | tilghman | 2008-05-07 14:40:21 -0400 (Wed, 07 May 2008) | 2 lines

        Don't free the object on destroy, as astobj2 takes care of that for you

        ................
        r115535 | tilghman | 2008-05-07 16:22:09 -0400 (Wed, 07 May 2008) | 2 lines

        Advance to next sounds release

        ................
        r115537 | russell | 2008-05-07 17:11:33 -0400 (Wed, 07 May 2008) | 10 lines

        Fix up a problem that was introduced into the scheduler when it was converted
        to use doubly linked lists. The schedule() function had an optimization that
        had it try to guess which direction would be better for the traversal to insert
        the task into the scheduler queue. However, if the code chose the path where
        it traversed the queue in reverse, and the result was that the task should be
        at the head of the queue, then the code would actually put it at the tail,
        instead.

        (Problem found by bbryant, debugged and fixed by bbryant and me)

        ................
        r115546 | russell | 2008-05-08 10:41:12 -0400 (Thu, 08 May 2008) | 12 lines

        Merged revisions 115545 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115545 | russell | 2008-05-08 09:40:53 -0500 (Thu, 08 May 2008) | 4 lines

        Use the same method for executing Asterisk as the rest of the script.
        (closes issue ASTERISK-11997)
        Reported by: b_plessis

        ........

        ................
        r115548 | mattf | 2008-05-08 11:04:45 -0400 (Thu, 08 May 2008) | 1 line

        Remove unused code as well as demote an error message to a debug message
        ................
        r115552 | russell | 2008-05-08 11:26:49 -0400 (Thu, 08 May 2008) | 12 lines

        Merged revisions 115551 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115551 | russell | 2008-05-08 10:24:54 -0500 (Thu, 08 May 2008) | 4 lines

        Don't use a channel before checking for channel allocation failure.
        (closes issue ASTERISK-11995)
        Reported by: edantie

        ........

        ................
        r115555 | russell | 2008-05-08 11:32:48 -0400 (Thu, 08 May 2008) | 11 lines

        Merged revisions 115554 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115554 | russell | 2008-05-08 10:32:08 -0500 (Thu, 08 May 2008) | 3 lines

        Don't exit the script if Asterisk is not running.
        (closes issue ASTERISK-11997)

        ........

        ................
        r115558 | russell | 2008-05-08 11:38:27 -0400 (Thu, 08 May 2008) | 11 lines

        Merged revisions 115557 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines

        remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well
        (closes issue ASTERISK-9393)

        ........

        ................
        r115562 | russell | 2008-05-08 12:14:08 -0400 (Thu, 08 May 2008) | 11 lines

        Merged revisions 115561 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115561 | russell | 2008-05-08 11:11:33 -0500 (Thu, 08 May 2008) | 3 lines

        Don't give up on attempting an outbound registration if we receive a 408 Timeout.
        (closes issue ASTERISK-11744)

        ........

        ................
        r115566 | russell | 2008-05-08 15:17:04 -0400 (Thu, 08 May 2008) | 41 lines

        Merged revisions 115565 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ................
        r115565 | russell | 2008-05-08 14:15:25 -0500 (Thu, 08 May 2008) | 33 lines

        Merged revisions 115564 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.2

        ........
        r115564 | russell | 2008-05-08 14:14:04 -0500 (Thu, 08 May 2008) | 25 lines

        Fix a race condition that bbryant just found while doing some IAX2 testing.
        He was running Asterisk trunk running IAX2 calls through a few Asterisk boxes,
        however, the audio was extremely choppy. We looked at a packet trace and saw
        a storm of INVAL and VNAK frames being sent from one box to another.

        It turned out that what had happened was that one box tried to send a CONTROL
        frame before the 3 way handshake had completed. So, that frame did not include
        the destination call number, because it didn't have it yet. Part of our recent
        work for security issues included an additional check to ensure that frames that
        are supposed to include the destination call number have the correct one. This
        caused the frame to be rejected with an INVAL. The frame would get retransmitted
        for forever, rejected every time ...

        This race condition exists in all versions that got the security changes,
        in theory. However, it is really only likely that this would cause a problem in
        Asterisk trunk. There was a control frame being sent (SRCUPDATE) at the very
        beginning of the call, which does not exist in 1.2 or 1.4. However, I am fixing
        all versions that could potentially be affected by the introduced race condition.

        These changes are what bbryant and I came up with to fix the issue. Instead of
        simply dropping control frames that get sent before the handshake is complete,
        the code attempts to wait a little while, since in most cases, the handshake
        will complete very quickly. If it doesn't complete after yielding for a little
        while, then the frame gets dropped.

        ........

        ................

        ................
        r115569 | russell | 2008-05-08 15:20:35 -0400 (Thu, 08 May 2008) | 10 lines

        Merged revisions 115568 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r115568 | russell | 2008-05-08 14:19:50 -0500 (Thu, 08 May 2008) | 2 lines

        Remove debug output.

        ........

        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=115574

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 115574 _U team/seanbright/res-jabber-astobj2/ U team/seanbright/res-jabber-astobj2/channels/chan_h323.c U team/seanbright/res-jabber-astobj2/channels/chan_iax2.c U team/seanbright/res-jabber-astobj2/channels/chan_sip.c U team/seanbright/res-jabber-astobj2/channels/chan_zap.c U team/seanbright/res-jabber-astobj2/contrib/init.d/rc.debian.asterisk U team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldap-schema U team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldif D team/seanbright/res-jabber-astobj2/contrib/scripts/postgres_cdr.sql _U team/seanbright/res-jabber-astobj2/include/asterisk/dlinkedlists.h U team/seanbright/res-jabber-astobj2/main/pbx.c U team/seanbright/res-jabber-astobj2/main/sched.c U team/seanbright/res-jabber-astobj2/res/res_config_ldap.c U team/seanbright/res-jabber-astobj2/res/res_odbc.c U team/seanbright/res-jabber-astobj2/sounds/Makefile ------------------------------------------------------------------------ r115574 | seanbright | 2008-05-08 19:10:45 -0500 (Thu, 08 May 2008) | 243 lines Merged revisions 115507,115509,115513,115515,115518-115519,115521,115523,115525,115535,115537,115546,115548,115552,115555,115558,115562,115566,115569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r115507 | file | 2008-05-07 09:41:25 -0400 (Wed, 07 May 2008) | 4 lines Remove redundant header getting. (closes issue ASTERISK-11984 ) Reported by: hooi ................ r115509 | tilghman | 2008-05-07 09:49:15 -0400 (Wed, 07 May 2008) | 6 lines Update typos in description fields (closes issue ASTERISK-11985 ) Reported by: suretec Patches: asterisk_schema_changes.patch uploaded by suretec (license 70) ................ r115513 | russell | 2008-05-07 13:28:19 -0400 (Wed, 07 May 2008) | 19 lines Merged revisions 115512 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r115512 | russell | 2008-05-07 11:24:09 -0500 (Wed, 07 May 2008) | 11 lines Merged revisions 115511 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r115511 | russell | 2008-05-07 11:22:49 -0500 (Wed, 07 May 2008) | 3 lines Remove remnants of dlinkedlists. I didn't actually use them in the final version of my IAX2 improvements. ........ ................ ................ r115515 | russell | 2008-05-07 13:38:36 -0400 (Wed, 07 May 2008) | 2 lines re-add dlinkedlists.h to trunk, oops! ................ r115518 | russell | 2008-05-07 14:17:43 -0400 (Wed, 07 May 2008) | 12 lines Blocked revisions 115517 via svnmerge ........ r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription. This fixes some realtime related crashes. (closes issue ASTERISK-11976 ) (closes issue ASTERISK-11945 ) ........ ................ r115519 | russell | 2008-05-07 14:24:51 -0400 (Wed, 07 May 2008) | 2 lines Let chan_h323 build in dev mode ................ r115521 | russell | 2008-05-07 14:30:12 -0400 (Wed, 07 May 2008) | 7 lines Use the default that the log output claims will be used for the basedn (closes issue ASTERISK-11986 ) Reported by: suretec Patches: 12599.patch uploaded by juggie (license 24) ................ r115523 | russell | 2008-05-07 14:33:50 -0400 (Wed, 07 May 2008) | 6 lines Only save a password if a username exists. (closes issue ASTERISK-11987 ) Reported By: suretec Patch by me ................ r115525 | tilghman | 2008-05-07 14:40:21 -0400 (Wed, 07 May 2008) | 2 lines Don't free the object on destroy, as astobj2 takes care of that for you ................ r115535 | tilghman | 2008-05-07 16:22:09 -0400 (Wed, 07 May 2008) | 2 lines Advance to next sounds release ................ r115537 | russell | 2008-05-07 17:11:33 -0400 (Wed, 07 May 2008) | 10 lines Fix up a problem that was introduced into the scheduler when it was converted to use doubly linked lists. The schedule() function had an optimization that had it try to guess which direction would be better for the traversal to insert the task into the scheduler queue. However, if the code chose the path where it traversed the queue in reverse, and the result was that the task should be at the head of the queue, then the code would actually put it at the tail, instead. (Problem found by bbryant, debugged and fixed by bbryant and me) ................ r115546 | russell | 2008-05-08 10:41:12 -0400 (Thu, 08 May 2008) | 12 lines Merged revisions 115545 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115545 | russell | 2008-05-08 09:40:53 -0500 (Thu, 08 May 2008) | 4 lines Use the same method for executing Asterisk as the rest of the script. (closes issue ASTERISK-11997 ) Reported by: b_plessis ........ ................ r115548 | mattf | 2008-05-08 11:04:45 -0400 (Thu, 08 May 2008) | 1 line Remove unused code as well as demote an error message to a debug message ................ r115552 | russell | 2008-05-08 11:26:49 -0400 (Thu, 08 May 2008) | 12 lines Merged revisions 115551 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115551 | russell | 2008-05-08 10:24:54 -0500 (Thu, 08 May 2008) | 4 lines Don't use a channel before checking for channel allocation failure. (closes issue ASTERISK-11995 ) Reported by: edantie ........ ................ r115555 | russell | 2008-05-08 11:32:48 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115554 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115554 | russell | 2008-05-08 10:32:08 -0500 (Thu, 08 May 2008) | 3 lines Don't exit the script if Asterisk is not running. (closes issue ASTERISK-11997 ) ........ ................ r115558 | russell | 2008-05-08 11:38:27 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115557 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well (closes issue ASTERISK-9393 ) ........ ................ r115562 | russell | 2008-05-08 12:14:08 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115561 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115561 | russell | 2008-05-08 11:11:33 -0500 (Thu, 08 May 2008) | 3 lines Don't give up on attempting an outbound registration if we receive a 408 Timeout. (closes issue ASTERISK-11744 ) ........ ................ r115566 | russell | 2008-05-08 15:17:04 -0400 (Thu, 08 May 2008) | 41 lines Merged revisions 115565 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r115565 | russell | 2008-05-08 14:15:25 -0500 (Thu, 08 May 2008) | 33 lines Merged revisions 115564 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r115564 | russell | 2008-05-08 14:14:04 -0500 (Thu, 08 May 2008) | 25 lines Fix a race condition that bbryant just found while doing some IAX2 testing. He was running Asterisk trunk running IAX2 calls through a few Asterisk boxes, however, the audio was extremely choppy. We looked at a packet trace and saw a storm of INVAL and VNAK frames being sent from one box to another. It turned out that what had happened was that one box tried to send a CONTROL frame before the 3 way handshake had completed. So, that frame did not include the destination call number, because it didn't have it yet. Part of our recent work for security issues included an additional check to ensure that frames that are supposed to include the destination call number have the correct one. This caused the frame to be rejected with an INVAL. The frame would get retransmitted for forever, rejected every time ... This race condition exists in all versions that got the security changes, in theory. However, it is really only likely that this would cause a problem in Asterisk trunk. There was a control frame being sent (SRCUPDATE) at the very beginning of the call, which does not exist in 1.2 or 1.4. However, I am fixing all versions that could potentially be affected by the introduced race condition. These changes are what bbryant and I came up with to fix the issue. Instead of simply dropping control frames that get sent before the handshake is complete, the code attempts to wait a little while, since in most cases, the handshake will complete very quickly. If it doesn't complete after yielding for a little while, then the frame gets dropped. ........ ................ ................ r115569 | russell | 2008-05-08 15:20:35 -0400 (Thu, 08 May 2008) | 10 lines Merged revisions 115568 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115568 | russell | 2008-05-08 14:19:50 -0500 (Thu, 08 May 2008) | 2 lines Remove debug output. ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115574

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development