Summary:	ASTERISK-09835: autofill reports and behaves in 2 different ways
Reporter:	Gregory Hinton Nietsky (irroot)	Labels:
Date Opened:	2007-07-08 10:29:54	Date Closed:	2007-10-12 09:25:51
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	in function  is_our_turn only interfaces in states unknown/not inuse are concidered for availability (this bypasses all call-limit settings and the like) yet when the call is placed normal strategy rules are applied. this is confusing ... i came accross this when implementing a call-limit bypass on a per member basis that will only concider them when free. if there is a demand for this ill post the patch.
Comments:	By: BJ Weschke (bweschke) 2007-08-24 14:24:09 The only thing I see us not doing that we should probably be doing is excluding members that are paused in the current queue from being counted as "available". As far as call-limits,etc I think these are being imposed on the channel driver level and it should be the responsibility of the channel driver to report itself as "BUSY or INUSE" back to the core which app_queue will in turn receive and act on appropriately. By: BJ Weschke (bweschke) 2007-08-24 14:24:42 please let me know if you feel differently. By: Digium Subversion (svnbot) 2007-08-24 14:34:02 Repository: asterisk Revision: 80818 ------------------------------------------------------------------------ r80818 | bweschke | 2007-08-24 14:34:01 -0500 (Fri, 24 Aug 2007) | 3 lines A minor correction to the available logic of autofill. If a queue member is paused, they're not really "available" so don't count them as such. Somewhat related to issue ASTERISK-9835 ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-24 15:03:12 Repository: asterisk Revision: 80819 ------------------------------------------------------------------------ r80819 | bweschke | 2007-08-24 15:03:12 -0500 (Fri, 24 Aug 2007) | 11 lines Merged revisions 80818 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80818 | bweschke | 2007-08-24 15:52:06 -0400 (Fri, 24 Aug 2007) | 3 lines A minor correction to the available logic of autofill. If a queue member is paused, they're not really "available" so don't count them as such. Somewhat related to issue ASTERISK-9835 ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-24 16:59:54 Repository: asterisk Revision: 80877 ------------------------------------------------------------------------ r80877 | murf | 2007-08-24 16:59:52 -0500 (Fri, 24 Aug 2007) | 70 lines Merged revisions 80790,80817,80819,80821,80850 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r80790 | murf | 2007-08-24 13:03:39 -0600 (Fri, 24 Aug 2007) | 9 lines Merged revisions 80789 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80789 | murf | 2007-08-24 12:52:15 -0600 (Fri, 24 Aug 2007) | 1 line From a complaint by jmls, I realize that the message in cdr_disposition is unnecessary. To get failure disposition, just return -1; no use having more than one case do that. ........ ................ r80817 | tilghman | 2007-08-24 13:50:16 -0600 (Fri, 24 Aug 2007) | 2 lines Fix documentation for Set (closes issue ASTERISK-10160) ................ r80819 | bweschke | 2007-08-24 14:21:17 -0600 (Fri, 24 Aug 2007) | 11 lines Merged revisions 80818 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80818 | bweschke | 2007-08-24 15:52:06 -0400 (Fri, 24 Aug 2007) | 3 lines A minor correction to the available logic of autofill. If a queue member is paused, they're not really "available" so don't count them as such. Somewhat related to issue ASTERISK-9835 ........ ................ r80821 | russell | 2007-08-24 14:25:39 -0600 (Fri, 24 Aug 2007) | 15 lines Merged revisions 80820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80820 | russell | 2007-08-24 15:24:05 -0500 (Fri, 24 Aug 2007) | 7 lines Improve the debouncing logic in the DTMF detector to fix some reliability issues.  Previously, this code used a shift register of hits and non-hits. However, if the start of the digit isn't clean, it is possible for the leading edge detector to miss the digit.  These changes replace the flawed shift register logic and also does the debouncing on the trailing edge as well. (closes issue ASTERISK-10148, many thanks to softins for the patch) ........ ................ r80850 | russell | 2007-08-24 15:23:14 -0600 (Fri, 24 Aug 2007) | 13 lines Merged revisions 80849 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80849 | russell | 2007-08-24 16:22:50 -0500 (Fri, 24 Aug 2007) | 5 lines If dnsmgr is in use, and no DNS servers are available when Asterisk first starts, then don't give up on poking peers.  Allow the poke to get rescheduled so that it will work once the dnsmgr is able to resolve the host. (closes issue ASTERISK-10138, patch by jamesgolovich) ........ ................ ------------------------------------------------------------------------ By: Mark Michelson (mmichelson) 2007-10-12 09:25:32 I agree with bweschke on this. His comments in his first bug note sum things up nicely. Since there have been no replies on this note for quite a while, I am going to close this. It can be reopened later if deemed necessary.