Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: NewFeature
    • Labels:
      None
    • Mantis ID:
      13760
    • Regression:
      No

      Description

      This patch block every reverse/collect calls on a ISDN trunk.
      So, once patched, asterisk will never receive these calls.

                • ADDITIONAL INFORMATION ******

      diff -uNr libpri-1.4.7/q931.c libpri-1.4.7-mod/q931.c
      — libpri-1.4.7/q931.c 2008-08-05 19:18:12.000000000 -0300
      +++ libpri-1.4.7-mod/q931.c 2008-10-17 14:28:51.000000000 -0200
      @@ -2545,6 +2545,7 @@
      int full_ie = Q931_FULL_IE(codeset, ie->ie);
      if (pri->debug & PRI_DEBUG_Q931_STATE)
      pri_message(pri, "-- Processing IE %d (cs%d, %s)\n", ie->ie, codeset, ie2str(full_ie));
      + if (strcmp(ie2str(full_ie), "Reverse Charging Indication") == 0) sleep(10);
      for (x=0;x<sizeof(ies) / sizeof(ies[0]);x++) {
      if (full_ie == ies[x].ie) {
      if (ies[x].receive)

        Activity

        Hide
        Digium Subversion added a comment -

        Repository: libpri
        Revision: 907

        U branches/1.4/libpri.h
        U branches/1.4/pri.c
        U branches/1.4/pri_internal.h
        U branches/1.4/q931.c

        ------------------------------------------------------------------------
        r907 | seanbright | 2009-06-25 13:53:38 -0500 (Thu, 25 Jun 2009) | 17 lines

        Add support for sending Reverse Charging Indication IE on ISDN PRI.

        Add the ability to transmit a Reverse Charging Indication IE during a SETUP
        message. In passing, re-work some of the receive logic to be forwards
        compatible with new RCI values that may be added in the future. Also removed
        the PRI_REVERSECHARGE_SUPPORT define that I added on the last commit since we
        can just check for PRI_REVERSECHARGE_NONE or _REQUESTED on the Asterisk side to
        determine support for this.

        Special thanks to rmudgett who could have written this in half the time he spent
        reviewing it, but instead talked me through it. Much appreciated!

        (issue PRI-46)
        Reported by: mrgabu

        Review: https://reviewboard.asterisk.org/r/292/

        ------------------------------------------------------------------------

        http://svn.digium.com/view/libpri?view=rev&revision=907

        Show
        Digium Subversion added a comment - Repository: libpri Revision: 907 U branches/1.4/libpri.h U branches/1.4/pri.c U branches/1.4/pri_internal.h U branches/1.4/q931.c ------------------------------------------------------------------------ r907 | seanbright | 2009-06-25 13:53:38 -0500 (Thu, 25 Jun 2009) | 17 lines Add support for sending Reverse Charging Indication IE on ISDN PRI. Add the ability to transmit a Reverse Charging Indication IE during a SETUP message. In passing, re-work some of the receive logic to be forwards compatible with new RCI values that may be added in the future. Also removed the PRI_REVERSECHARGE_SUPPORT define that I added on the last commit since we can just check for PRI_REVERSECHARGE_NONE or _REQUESTED on the Asterisk side to determine support for this. Special thanks to rmudgett who could have written this in half the time he spent reviewing it, but instead talked me through it. Much appreciated! (issue PRI-46 ) Reported by: mrgabu Review: https://reviewboard.asterisk.org/r/292/ ------------------------------------------------------------------------ http://svn.digium.com/view/libpri?view=rev&revision=907
        Hide
        Sean Bright added a comment -

        Note that the commit to LibPRI has a slightly different implementation than the attached patches. The patch attached for Asterisk will not work with LibPRI from SVN. Another Asterisk patch is forthcoming.

        Show
        Sean Bright added a comment - Note that the commit to LibPRI has a slightly different implementation than the attached patches. The patch attached for Asterisk will not work with LibPRI from SVN. Another Asterisk patch is forthcoming.
        Hide
        Sean Bright added a comment -

        Actually, I really don't know how to proceed here. I am going to unassign and hopefully someone else can pick up the Asterisk side of things.

        Show
        Sean Bright added a comment - Actually, I really don't know how to proceed here. I am going to unassign and hopefully someone else can pick up the Asterisk side of things.
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 204749

        U trunk/CHANGES
        U trunk/channels/chan_dahdi.c
        U trunk/channels/sig_pri.c
        U trunk/channels/sig_pri.h
        U trunk/configs/chan_dahdi.conf.sample
        U trunk/funcs/func_channel.c

        ------------------------------------------------------------------------
        r204749 | seanbright | 2009-07-02 12:46:14 -0500 (Thu, 02 Jul 2009) | 21 lines

        Support setting and receiving Reverse Charging Indication over ISDN PRI.

        This is a continuation of revision 885 to LibPRI (Capture and expose the Reverse
        Charging Indication IE on ISDN PRI) which added the ability to get/set Reverse
        Charging Indication in LibPRI. This patch adds the ability to specify RCI on
        the outbound leg of a PRI call from within Asterisk, by prefixing the dialed
        number with a capital 'C' like:

        ...,Dial(DAHDI/g1/C4445556666)

        And to read it off an inbound channel:

        exten => s,1,Set(RCI=$

        {CHANNEL(reversecharge)}

        )

        Thanks again to rmudgett for the thorough review.

        (closes issue PRI-46)
        Reported by: mrgabu

        Review: https://reviewboard.asterisk.org/r/303/

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=204749

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 204749 U trunk/CHANGES U trunk/channels/chan_dahdi.c U trunk/channels/sig_pri.c U trunk/channels/sig_pri.h U trunk/configs/chan_dahdi.conf.sample U trunk/funcs/func_channel.c ------------------------------------------------------------------------ r204749 | seanbright | 2009-07-02 12:46:14 -0500 (Thu, 02 Jul 2009) | 21 lines Support setting and receiving Reverse Charging Indication over ISDN PRI. This is a continuation of revision 885 to LibPRI (Capture and expose the Reverse Charging Indication IE on ISDN PRI) which added the ability to get/set Reverse Charging Indication in LibPRI. This patch adds the ability to specify RCI on the outbound leg of a PRI call from within Asterisk, by prefixing the dialed number with a capital 'C' like: ...,Dial(DAHDI/g1/C4445556666) And to read it off an inbound channel: exten => s,1,Set(RCI=$ {CHANNEL(reversecharge)} ) Thanks again to rmudgett for the thorough review. (closes issue PRI-46 ) Reported by: mrgabu Review: https://reviewboard.asterisk.org/r/303/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=204749
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 204750

        _U branches/1.6.2/

        ------------------------------------------------------------------------
        r204750 | seanbright | 2009-07-02 12:47:43 -0500 (Thu, 02 Jul 2009) | 27 lines

        Blocked revisions 204749 via svnmerge

        ........
        r204749 | seanbright | 2009-07-02 13:46:14 -0400 (Thu, 02 Jul 2009) | 21 lines

        Support setting and receiving Reverse Charging Indication over ISDN PRI.

        This is a continuation of revision 885 to LibPRI (Capture and expose the Reverse
        Charging Indication IE on ISDN PRI) which added the ability to get/set Reverse
        Charging Indication in LibPRI. This patch adds the ability to specify RCI on
        the outbound leg of a PRI call from within Asterisk, by prefixing the dialed
        number with a capital 'C' like:

        ...,Dial(DAHDI/g1/C4445556666)

        And to read it off an inbound channel:

        exten => s,1,Set(RCI=$

        {CHANNEL(reversecharge)}

        )

        Thanks again to rmudgett for the thorough review.

        (closes issue PRI-46)
        Reported by: mrgabu

        Review: https://reviewboard.asterisk.org/r/303/
        ........

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=204750

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 204750 _U branches/1.6.2/ ------------------------------------------------------------------------ r204750 | seanbright | 2009-07-02 12:47:43 -0500 (Thu, 02 Jul 2009) | 27 lines Blocked revisions 204749 via svnmerge ........ r204749 | seanbright | 2009-07-02 13:46:14 -0400 (Thu, 02 Jul 2009) | 21 lines Support setting and receiving Reverse Charging Indication over ISDN PRI. This is a continuation of revision 885 to LibPRI (Capture and expose the Reverse Charging Indication IE on ISDN PRI) which added the ability to get/set Reverse Charging Indication in LibPRI. This patch adds the ability to specify RCI on the outbound leg of a PRI call from within Asterisk, by prefixing the dialed number with a capital 'C' like: ...,Dial(DAHDI/g1/C4445556666) And to read it off an inbound channel: exten => s,1,Set(RCI=$ {CHANNEL(reversecharge)} ) Thanks again to rmudgett for the thorough review. (closes issue PRI-46 ) Reported by: mrgabu Review: https://reviewboard.asterisk.org/r/303/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=204750

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development